Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated S2 Table tokens #405

Draft
wants to merge 1 commit into
base: beta
Choose a base branch
from

Conversation

mrcjhicks
Copy link
Collaborator

@mrcjhicks mrcjhicks commented Aug 22, 2024

Created by Action: https://github.com/adobe/spectrum-tokens-studio-data/actions/runs/10511818984
Tokens Studio PR: adobe/spectrum-tokens-studio-data#161

Description

Updated tokens for the S2 Table component in S2 layout.component set.

table-column-header-row-top-to-text-medium
table-row-top-to-text-medium-regular
table-row-bottom-to-text-medium-regular
table-row-top-to-text-medium-spacious
table-header-row-checkbox-to-top-medium
table-row-checkbox-to-top-medium-compact
table-row-checkbox-to-top-medium-regular
table-row-checkbox-to-top-medium-spacious
Added new token to the S2 layout set:

side-focus-indicator
Tokens changes are reflected in both desktop and mobile sets.

Motivation and context

Table component is being formalized as a Spectrum 2 component. These updated tokens define the design data needed for implementation.

Copy link

changeset-bot bot commented Aug 22, 2024

⚠️ No Changeset found

Latest commit: a22a901

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@GarthDB
Copy link
Member

GarthDB commented Aug 22, 2024

Run report for a22a901b

Total time: 34.2s | Comparison time: 34s | Estimated loss: 172.3ms (0.5% slower)

Action Time Status Info
🟩 SyncWorkspace 4.9ms Passed
⬛️ SetupToolchain(node:~20.12) 1.3s Skipped
🟩 SyncProject(node, root) 0.2ms Passed
🟩 SyncProject(node, tokens) 0.3ms Passed
🟩 InstallWorkspaceDeps(node:~20.12) 7.3s Passed
🟩 RunTask(tokens:buildManifest) 258.2ms Passed
🟩 RunTask(root:test) 1.3s Passed
🟩 RunTask(tokens:buildTokens) 22.3s Passed
🟩 RunTask(tokens:build) 25ms Passed
🟩 RunTask(tokens:generateDiffResult) 2.7s Passed
🟥 RunTask(tokens:test) 3.3s Failed
Touched files
packages/tokens/src/color-aliases.json
packages/tokens/src/color-component.json
packages/tokens/src/color-palette.json
packages/tokens/src/layout-component.json
packages/tokens/src/semantic-color-palette.json

@GarthDB GarthDB changed the title feat: updates from spectrum-tokens-studio-data Updated S2 Table tokens Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants