Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in compare card when sharing url of report #387

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shirlsli
Copy link
Collaborator

Description

Implemented sharing via url for the diff generator website. The user is now able to send a link of their report to others and they'll be able to view the report without manually re-selecting the parameters.

Motivation and Context

My previous approach to handling the passing of parameters into the compare card component was very buggy, so I switched to having the compare card component read in parameters from the url instead of from its parent component.

How Has This Been Tested?

Currently there has only been manual testing done by me.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

changeset-bot bot commented Jul 30, 2024

⚠️ No Changeset found

Latest commit: 5681af2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@GarthDB
Copy link
Member

GarthDB commented Jul 30, 2024

Run report for 5681af2e

Total time: 17.4s | Comparison time: 22.8s | Estimated savings: 5.3s (23.4% faster)

Action Time Status Info
🟩 SyncWorkspace 4.7ms Passed
⬛️ SetupToolchain(node:~20.12) 1.3s Skipped
🟩 SyncProject(node, diff) 0.2ms Passed
🟩 SyncProject(node, root) 0.2ms Passed
🟩 SyncProject(node, tdiff) 0.2ms Passed
🟩 InstallWorkspaceDeps(node:~20.12) 10.6s Passed
🟩 RunTask(diff:diff) 121.6ms Passed
🟩 RunTask(root:test) 2.1s Passed
🟥 RunTask(tdiff:typescript) 5s Failed
⬛️ RunTask(tdiff:build) 0.2ms Skipped
🟩 RunTask(diff:test) 5.5s Passed
Touched files
docs/token-diff/index.d.ts
docs/token-diff/package.json
docs/token-diff/src/CodePanel.ts
docs/token-diff/src/CompareCard.ts
docs/token-diff/src/DiffReport.ts
docs/token-diff/src/GettingStarted.ts
docs/token-diff/src/NavBar.ts
docs/token-diff/src/PageContainer.ts
docs/token-diff/src/TokenDiff.ts
docs/token-diff/src/fetchFromGithub.ts
docs/token-diff/tsconfig.json
pnpm-lock.yaml
tools/diff-generator/src/lib/added-token-detection.js
tools/diff-generator/src/lib/cli.js
tools/diff-generator/src/lib/format-function.js
tools/diff-generator/test/fileImport.test.js
tools/diff-generator/test/snapshots/fileImport.test.js.md
tools/diff-generator/test/snapshots/fileImport.test.js.snap

@shirlsli shirlsli requested a review from GarthDB August 5, 2024 15:36
@shirlsli shirlsli marked this pull request as ready for review August 5, 2024 15:36
Base automatically changed from shirlsli/diff-generator-website-1 to main August 29, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants