chore: refactor component-schemas into package #353

karstens · 2024-06-07T14:30:14Z

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have signed the Adobe Open Source CLA.
My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

changeset-bot · 2024-06-07T14:30:18Z

⚠️ No Changeset found

Latest commit: cf73cf1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

packages/tokens/test/schemaValidator.test.js

GarthDB · 2024-06-13T15:27:18Z

Run report for dc2d6c6e

Total time: 40.8s | Comparison time: 1m 21s | Estimated savings: 40.2s (49.6% faster)

	Action	Time	Status
🟩	`SyncWorkspace`	4.9ms	Passed
⬛️	`SetupToolchain(node:~20.12)`	1.3s	Skipped
🟩	`SyncProject(node, diff)`	0.2ms	Passed
🟩	`SyncProject(node, root)`	0.3ms	Passed
🟩	`SyncProject(node, visualizer)`	0.3ms	Passed
🟩	`SyncProject(node, tokens)`	0.3ms	Passed
🟩	`SyncProject(node, componentSchemas)`	0.2ms	Passed
🟩	`SyncProject(node, site)`	0.2ms	Passed
🟩	`SyncProject(node, csvGenerator)`	0.2ms	Passed
🟩	`RunTask(site:copyTokenTypeSchema)`	60.1ms	Passed
🟩	`RunTask(site:copyComponentSchema)`	76.7ms	Passed
🟩	`InstallWorkspaceDeps(node:~20.12)`	7s	Passed
🟩	`RunTask(site:clean)`	193.1ms	Passed
🟩	`RunTask(csvGenerator:test)`	1.5s	Passed
🟩	`RunTask(diff:diff)`	145.7ms	Passed
🟩	`RunTask(root:test)`	2s	Passed
🟩	`RunTask(componentSchemas:test)`	2.5s	Passed
🟩	`RunTask(visualizer:typescript)`	7.2s	Passed
🟩	`RunTask(diff:test)`	7.9s	Passed
🟩	`RunTask(csvGenerator:generateCSV)`	434.2ms	Passed
	And 8 more...

Expanded report

	Action	Time	Status
🟩	`RunTask(tokens:buildManifest)`	395.8ms	Passed
🟩	`RunTask(visualizer:build)`	2.9s	Passed
🟩	`RunTask(site:build)`	25.7s	Passed
🟩	`RunTask(site:export)`	108.2ms	Passed
🟩	`RunTask(tokens:buildTokens)`	30.1s	Passed
🟩	`RunTask(tokens:build)`	19.3ms	Passed
🟩	`RunTask(tokens:generateDiffResult)`	1.9s	Passed
🟩	`RunTask(tokens:test)`	2.5s	Passed

Touched files

.changeset/pretty-carrots-camp.md
.github/workflows/release-snapshot.yml
.moon/workspace.yml
docs/site/lib/components.js
docs/site/moon.yml
docs/site/public/schemas/components/action-button.json
docs/site/public/schemas/components/avatar.json
docs/site/public/schemas/components/button.json
docs/site/public/schemas/components/close-button.json
docs/site/public/schemas/components/link.json
docs/site/public/schemas/components/popover.json
docs/site/public/schemas/components/rating.json
docs/site/public/schemas/components/search-field.json
docs/site/public/schemas/components/tabs.json
packages/component-schemas/CHANGELOG.md
packages/component-schemas/README.md
packages/component-schemas/index.js
packages/component-schemas/moon.yml
packages/component-schemas/package.json
packages/component-schemas/schemas/component.json
packages/component-schemas/schemas/components/action-bar.json
packages/component-schemas/schemas/components/action-button.json
packages/component-schemas/schemas/components/action-group.json
packages/component-schemas/schemas/components/alert-banner.json
packages/component-schemas/schemas/components/alert-dialog.json
packages/component-schemas/schemas/components/avatar.json
packages/component-schemas/schemas/components/badge.json
packages/component-schemas/schemas/components/body.json
packages/component-schemas/schemas/components/bottom-navigation-android.json
packages/component-schemas/schemas/components/breadcrumbs.json
packages/component-schemas/schemas/components/button-group.json
packages/component-schemas/schemas/components/button.json
packages/component-schemas/schemas/components/checkbox-group.json
packages/component-schemas/schemas/components/checkbox.json
packages/component-schemas/schemas/components/close-button.json
packages/component-schemas/schemas/components/code.json
packages/component-schemas/schemas/components/color-area.json
packages/component-schemas/schemas/components/color-loupe.json
packages/component-schemas/schemas/components/color-slider.json
packages/component-schemas/schemas/components/color-wheel.json
packages/component-schemas/schemas/components/combo-box.json
packages/component-schemas/schemas/components/contextual-help.json
packages/component-schemas/schemas/components/detail.json
packages/component-schemas/schemas/components/divider.json
packages/component-schemas/schemas/components/field-label.json
packages/component-schemas/schemas/components/heading.json
packages/component-schemas/schemas/components/help-text.json
packages/component-schemas/schemas/components/in-line-alert.json
packages/component-schemas/schemas/components/link.json
packages/component-schemas/schemas/components/menu.json
packages/component-schemas/schemas/components/meter.json
packages/component-schemas/schemas/components/picker.json
packages/component-schemas/schemas/components/popover.json
packages/component-schemas/schemas/components/progress-bar.json
packages/component-schemas/schemas/components/progress-circle.json
packages/component-schemas/schemas/components/radio-group.json
packages/component-schemas/schemas/components/rating.json
packages/component-schemas/schemas/components/scroll-zoom-bar.json
packages/component-schemas/schemas/components/search-field.json
packages/component-schemas/schemas/components/side-navigation.json
packages/component-schemas/schemas/components/slider.json
packages/component-schemas/schemas/components/status-light.json
packages/component-schemas/schemas/components/swatch-group.json
packages/component-schemas/schemas/components/swatch.json
packages/component-schemas/schemas/components/switch.json
packages/component-schemas/schemas/components/tab-bar-ios.json
packages/component-schemas/schemas/components/tabs.json
packages/component-schemas/schemas/components/tag.json
packages/component-schemas/schemas/components/text-area.json
packages/component-schemas/schemas/components/text-field.json
packages/component-schemas/schemas/components/toast.json
packages/component-schemas/schemas/components/tooltip.json
packages/component-schemas/schemas/components/tray.json
packages/component-schemas/schemas/components/tree-view.json
packages/component-schemas/schemas/types/hex-color.json
packages/component-schemas/schemas/types/typography-classification.json
packages/component-schemas/schemas/types/typography-script.json
packages/component-schemas/schemas/types/workflow-icon.json
packages/component-schemas/test/componentSchemaValidator.test.js
packages/component-schemas/test/index.test.js
packages/component-schemas/test/snapshots/index.test.js.md
packages/component-schemas/test/snapshots/index.test.js.snap
packages/tokens/schemas/component.json
packages/tokens/schemas/components/action-bar.json
packages/tokens/schemas/components/action-button.json
packages/tokens/schemas/components/action-group.json
packages/tokens/schemas/components/alert-banner.json
packages/tokens/schemas/components/alert-dialog.json
packages/tokens/schemas/components/avatar.json
packages/tokens/schemas/components/badge.json
packages/tokens/schemas/components/body.json
packages/tokens/schemas/components/bottom-navigation-android.json
packages/tokens/schemas/components/breadcrumbs.json
packages/tokens/schemas/components/button-group.json
packages/tokens/schemas/components/button.json
packages/tokens/schemas/components/checkbox-group.json
packages/tokens/schemas/components/checkbox.json
packages/tokens/schemas/components/close-button.json
packages/tokens/schemas/components/code.json
packages/tokens/schemas/components/color-area.json
packages/tokens/schemas/components/color-loupe.json
packages/tokens/schemas/components/color-slider.json
packages/tokens/schemas/components/color-wheel.json
packages/tokens/schemas/components/combo-box.json
packages/tokens/schemas/components/contextual-help.json
packages/tokens/schemas/components/detail.json
packages/tokens/schemas/components/divider.json
packages/tokens/schemas/components/field-label.json
packages/tokens/schemas/components/heading.json
packages/tokens/schemas/components/help-text.json
packages/tokens/schemas/components/in-line-alert.json
packages/tokens/schemas/components/link.json
packages/tokens/schemas/components/menu.json
packages/tokens/schemas/components/meter.json
packages/tokens/schemas/components/picker.json
packages/tokens/schemas/components/popover.json
packages/tokens/schemas/components/progress-bar.json
packages/tokens/schemas/components/progress-circle.json
packages/tokens/schemas/components/radio-group.json
packages/tokens/schemas/components/rating.json
packages/tokens/schemas/components/scroll-zoom-bar.json
packages/tokens/schemas/components/side-navigation.json
packages/tokens/schemas/components/slider.json
packages/tokens/schemas/components/status-light.json
packages/tokens/schemas/components/swatch-group.json
packages/tokens/schemas/components/swatch.json
packages/tokens/schemas/components/switch.json
packages/tokens/schemas/components/tab-bar-ios.json
packages/tokens/schemas/components/tabs.json
packages/tokens/schemas/components/tag.json
packages/tokens/schemas/components/text-area.json
packages/tokens/schemas/components/text-field.json
packages/tokens/schemas/components/toast.json
packages/tokens/schemas/components/tooltip.json
packages/tokens/schemas/components/tray.json
packages/tokens/schemas/components/tree-view.json
packages/tokens/schemas/types/component-size.json
packages/tokens/schemas/types/hex-color.json
packages/tokens/schemas/types/typography-classification.json
packages/tokens/schemas/types/typography-script.json
packages/tokens/schemas/types/workflow-icon.json
packages/tokens/test/componentSchemaValidator.test.js
packages/tokens/test/schemaValidator.test.js
pnpm-lock.yaml

GarthDB

I made a couple of changes to fix the tests in order to make a snapshot release.

packages/component-schemas/moon.yml

packages/component-schemas/test/componentSchemaValidator.test.js

packages/component-schemas/index.js

karstens · 2024-08-20T14:33:25Z

@GarthDB test fail because of the new tab-item-json schema. How can I fix it?
See test: https://github.com/adobe/spectrum-tokens/actions/runs/10473460083/job/29005364511?pr=353#step:4:312
See commit: 672d2d0

chore: refactor component-schemas into package

acb7cc0

karstens marked this pull request as draft June 7, 2024 14:30

karstens requested review from GarthDB and jianliao June 7, 2024 14:30

karstens commented Jun 7, 2024

View reviewed changes

packages/tokens/test/schemaValidator.test.js Show resolved Hide resolved

fix: used correct parameter in schema getFile function

5946a63

GarthDB added 4 commits June 13, 2024 09:28

ci: testing automated snapshot release

0e882f5

fix: addressed spectrum-component-api-schemas package name

4b8d625

ci: refactored moon tasks for schema pacakge

cdd1511

chore: added changeset

6ff5ad7

GarthDB force-pushed the karstens/DTT-2140--component-api-schemas branch from 3e15841 to 6ff5ad7 Compare June 13, 2024 15:46

chore: snapshot release schema

0727a14

GarthDB requested changes Jun 13, 2024

View reviewed changes

packages/component-schemas/moon.yml Outdated Show resolved Hide resolved

GarthDB requested changes Jun 13, 2024

View reviewed changes

packages/component-schemas/test/componentSchemaValidator.test.js Outdated Show resolved Hide resolved

GarthDB self-requested a review June 13, 2024 15:58

GarthDB requested changes Jun 13, 2024

View reviewed changes

packages/component-schemas/index.js Show resolved Hide resolved

jianliao reviewed Jun 13, 2024

View reviewed changes

packages/component-schemas/index.js Outdated Show resolved Hide resolved

packages/component-schemas/index.js Outdated Show resolved Hide resolved

GarthDB added 7 commits June 14, 2024 13:33

test: added tests to index.js file

58dfd16

chore: added changeset

9805167

chore: snapshot release schema

c85b576

ci: fixed snapshot release workflow

8017382

refactor: changed getAllSchemas format to include component slugs

f4ec282

refactor: removed unused component-size type

9034673

feat: initial release

7a42c4d

GarthDB force-pushed the karstens/DTT-2140--component-api-schemas branch from f47714f to a8a56c6 Compare June 18, 2024 05:33

chore: added changeset

b5c1579

GarthDB force-pushed the karstens/DTT-2140--component-api-schemas branch from a8a56c6 to b5c1579 Compare June 18, 2024 05:36

chore: snapshot release schema

3bbc12b

GarthDB and others added 12 commits June 18, 2024 14:33

feat: added missing search-field schema

8d4e05b

fix: schema path checks

c2cfa56

test: resolved some absolute path bugs in the tests

ebe6186

chore: added changeset

64379eb

chore: snapshot release schema

d3c609f

fix: tabs and tab-item jsonSchema

672d2d0

fix: size property for action-button jsonSchema

93b6799

fix: image property for avatar jsonSchema

dfd67f5

fix: static color property description

f1ac034

fix: integer as property value type

e08891d

Merge branch 'main' into karstens/DTT-2140--component-api-schemas

0787706

fix: pnpm-lock.yaml

fdb7cf6

karstens and others added 5 commits August 20, 2024 20:28

fix: add tab-item as children to tabs json schema

2811d29

fix: run build to publish changed json schemas to docs/site/public

1f2fc6d

fix: remove children from tabs.json and remove tab-item-json

13ce53a

chore: added changeset

dc2d6c6

chore: snapshot release schema

cf73cf1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: refactor component-schemas into package #353

chore: refactor component-schemas into package #353

karstens commented Jun 7, 2024 •

edited

Loading

changeset-bot bot commented Jun 7, 2024 •

edited

Loading

GarthDB commented Jun 13, 2024 •

edited

Loading

GarthDB left a comment

karstens commented Aug 20, 2024 •

edited

Loading

chore: refactor component-schemas into package #353

Are you sure you want to change the base?

chore: refactor component-schemas into package #353

Conversation

karstens commented Jun 7, 2024 • edited Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

changeset-bot bot commented Jun 7, 2024 • edited Loading

⚠️ No Changeset found

GarthDB commented Jun 13, 2024 • edited Loading

Run report for dc2d6c6e

GarthDB left a comment

Choose a reason for hiding this comment

karstens commented Aug 20, 2024 • edited Loading

karstens commented Jun 7, 2024 •

edited

Loading

changeset-bot bot commented Jun 7, 2024 •

edited

Loading

GarthDB commented Jun 13, 2024 •

edited

Loading

karstens commented Aug 20, 2024 •

edited

Loading