-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(search): storybook doc migrations #3174
Conversation
|
🚀 Deployed on https://pr-3174--spectrum-css.netlify.app |
File metricsSummaryTotal size: 4.31 MB* 🎉 No changes detected in any packages * Size determined by adding together the size of the main file for all packages in the library.* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I left one small comment about how our clear button behaves, but I don't think that necessarily needs to block merging!
* A search field is used for searching and filtering items. | ||
* | ||
* ## Usage Notes | ||
* This component contains a single input field with both a magnifying glass icon and a clear (“reset”) button displayed within it. When making use of this component, the clear button should only be displayed when the input has a value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the clear button should only be displayed when the input has a value.
I'm seeing the clear button on this all the time (except when the component is disabled), I'm wondering if that's a change we would want to make to our template at some point?
91fe168
to
71eff67
Compare
Description
Added disabled, quiet, helptext docs
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Search
now has theHelpText
component incomponents/search/template.js
.Disabled
stateboolean
control in storyRegression testing
Validate:
Screenshots
To-do list