feat(tokens): use @adobe/[email protected] + apply CJK typography changes #3167
+98
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 88d0984 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
🚀 Deployed on https://pr-3167--spectrum-css.netlify.app |
File metricsSummaryTotal size: 4.31 MB* Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.
Detailstypography
tokens
* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
pfulton
force-pushed
the
pfulton/s1-cjk-fix
branch
3 times, most recently
from
3bc94b0
to
0de5d00
Compare
pfulton
commented
Sep 27, 2024
pfulton
added
size-1 XS
pfulton
force-pushed
the
pfulton/s1-cjk-fix
branch
from
0de5d00
to
9544656
Compare
rise-erpelding
approved these changes
Sep 30, 2024
Updates the typography styles to introduce specialized font sizes for cjk at different t-shirt sizes. Additionally, changes the weight and letter-spacing for some of those styles.
pfulton
force-pushed
the
pfulton/s1-cjk-fix
branch
from
9544656
to
88d0984
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Takes in the
12.27.0release of@adobe/spectrum-tokenswhich includes additions and changes for CJK typography. While there are 27 additions or changes in that release, the downstream scope of changes is much more broad, as these changes will impact any consumer using Typography styles for CJK locales, the Illustrated Message component for CJK locales, and the Drop Zone component for CJK locales.Affected components:
Visual testing
Unfortunately, we don't have visual tests that cover these changes, so Chromatic isn't detecting any changes.
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
18px) compared to production which uses--spectrum-body-font-sizeand renders at20px.Regression testing
Validate:
Screenshots
BEFORE (current production, XL size):
AFTER (deploy URL, XL size):
To-do list