Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(coachmark)!: migrate tokens #1992

Closed
wants to merge 65 commits into from
Closed

Conversation

jenndiaz
Copy link
Contributor

@jenndiaz jenndiaz commented Jul 5, 2023

Description

Migrates tokens and implements new styling for coach mark

  • Splits the coach mark indicator and coach mark popover into 2 separate components, CoachIndicator and CoachMark
  • is "responsive" and displays different button and menu styling for Large scale (mobile)
  • Updates stories for both components

Jira Ticket - CSS 193

XD File

How and where has this been tested?

  • How this was tested:
  • Browser(s) and OS(s) this was tested with:
    Browser(s) and OS(s) this was tested with:
    Chrome Version 113.0.5672.63 on macOS
    Safari 16.4 on macOS
    Firefox 112.0.2 on macOS

Regression testing

Test Outline @jawinn

  1. Open the docs site for the CoachMark component.
  • component should display mobile styling when scale is Large
  • styling should match XD files
  1. Open the storybook site for the CoachMark component
  • controls should all function as expected
  • styling should match docs site
  1. Open the docs site for the CoachIndicator component.
  • Styling should match the live docs site
  1. Open the storybook site for the CoachIndicator component
  • controls should all function as expected @jawinn : except as noted in comment about reduceMotion
  • styling should match docs site

Validate: @jawinn

  1. A legacy documentation page (such as accordion), including:
  • The page renders correctly
  • The page is accessible
  • The page is responsive
  1. A migrated documentation page (such as action group), including:
  • The page renders correctly
  • The page is accessible
  • The page is responsive

Screenshots

Desktop (medium)

Screenshot 2023-08-24 at 11 06 59 AM
Screenshot 2023-08-24 at 11 06 48 AM

Mobile (Large)

Screenshot 2023-08-24 at 11 07 57 AM
Screenshot 2023-08-24 at 11 08 06 AM

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have tested these changes in Windows High Contrast mode.
  • I have updated any relevant storybook stories and templates.
  • If my change(s) include visual change(s), a designer has reviewed and approved those changes.
  • This pull request is ready to merge.

@jenndiaz jenndiaz force-pushed the jenndiaz/css-193-coachmark branch from 4846c77 to 09761a2 Compare July 5, 2023 17:34
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

🚀 Deployed on https://pr-1992--spectrum-css.netlify.app

@github-actions github-actions bot temporarily deployed to pull request July 5, 2023 18:02 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 5, 2023 22:04 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 6, 2023 20:33 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 6, 2023 21:57 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 7, 2023 19:17 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 7, 2023 19:43 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 7, 2023 22:16 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 28, 2023 21:10 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 9, 2023 19:59 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 9, 2023 21:54 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 9, 2023 22:28 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 18, 2023 20:44 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 18, 2023 21:33 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 18, 2023 22:19 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 18, 2023 22:46 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 22, 2023 21:34 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 24, 2023 16:48 Inactive
@jenndiaz jenndiaz marked this pull request as ready for review August 24, 2023 16:52
@github-actions github-actions bot temporarily deployed to pull request August 24, 2023 17:22 Inactive
@jenndiaz jenndiaz added run_vrt For use on PRs looking to kick off VRT and removed do not merge A flag for a branch indicating it should not be merged. labels Nov 29, 2023
Copy link
Contributor

github-actions bot commented Nov 29, 2023

File metrics

Overall Δ: +36.35 KB ⬆ (+0.99%)

buttongroup

-< 1KB ⬇

File Size Diff Δ Δ%
Total changes 7.00 KB 6.99 KB -< 1KB ⬇ -0.17%
index-base.css 1.90 KB 1.90 KB -< 1KB ⬇ -0.21%
index-theme.css < 1KB < 1KB No change 🎉 0%
index-vars.css 1.90 KB 1.90 KB -< 1KB ⬇ -0.21%
index.css 1.90 KB 1.90 KB -< 1KB ⬇ -0.21%
mods.json < 1KB < 1KB No change 🎉 0%
themes/express.css < 1KB < 1KB No change 🎉 0%
themes/spectrum.css < 1KB < 1KB No change 🎉 0%

coachmark

-4.54 KB ⬇

File Size Diff Δ Δ%
Total changes 12.25 KB 7.71 KB -4.54 KB ⬇ -37.04%
index-vars.css 9.10 KB 7.71 KB -1.38 KB ⬇ -15.22%
vars.css 3.15 KB new

@pfulton
Copy link
Collaborator

pfulton commented Dec 4, 2023

Closed in favor of #2323

@pfulton pfulton closed this Dec 4, 2023
@castastrophe castastrophe deleted the jenndiaz/css-193-coachmark branch March 6, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-swc-validation Being reviewed in/by SWC; required for breaking changes released-beta Indicates a beta release has been rolled for this PR run_vrt For use on PRs looking to kick off VRT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants