fix(slider,radio): dir before pseudo element (#2744)

adobe · May 22, 2024 · e1ef34f · e1ef34f
1 parent 1d19c7a
commit e1ef34f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/.changeset/neat-windows-yawn.md b/.changeset/neat-windows-yawn.md
@@ -0,0 +1,6 @@
+---
+"@spectrum-css/slider": patch
+"@spectrum-css/radio": patch
+---
+
+Includes similar fixes for both Slider and Radio. Some parsers see `:pseudo:dir` as invalid, so we've changed it so that the pseudo element comes last `:dir :pseudo`.
diff --git a/components/radio/index.css b/components/radio/index.css
@@ -421,7 +421,7 @@ governing permissions and limitations under the License.
 			opacity var(--mod-radio-animation-duration, var(--spectrum-radio-animation-duration)) ease-out,
 			margin var(--mod-radio-animation-duration, var(--spectrum-radio-animation-duration)) ease-out;
 
-		&:dir(rtl) {
+		.spectrum-Radio:dir(rtl) & {
 			transform: translateX(50%) translateY(-50%);
 		}
 	}

diff --git a/components/slider/index.css b/components/slider/index.css
@@ -348,7 +348,7 @@ governing permissions and limitations under the License.
 
 		transform: translate(-50%, -50%);
 
-		&:dir(rtl) {
+		.spectrum-Slider:dir(rtl) & {
 			transform: translate(50%, -50%);
 		}
 	}