Skip to content

Commit

Permalink
feat(fieldlabel)!: s2 migration (#2569)
Browse files Browse the repository at this point in the history
BREAKING CHANGE: uses Spectrum 2 tokens

Also:
* feat(fieldlabel): medium as default and 100 sizing tokens

- Use the correct "100" sized tokens for medium.
- Make medium styles the default, to conform with existing pattern.
  .spectrum-FieldLabel--sizeM class removed as it is no longer
  necessary.

* feat(fieldlabel): use correct font size tokens

The font-size tokens used for large and extra large needed to be shifted
up to match the s2 spec.

* refactor(fieldlabel): remove deprecated mods

Remove renamed mods marked as deprecated for S2 release.

* docs(fieldlabel): spectrum 2 noted in migration notes

Updates some docs and adds migration notes. Clarifies some docs around
"left" and "right", and fixes duplicate ID warnings from examples code.

* docs(fieldlabel): form - docs update and regenerate mods

Add migration guide section to "Form", that currently lives within the
Field label component. Regenerates mods to include the removal of
deprecated renamed mods.

* fix(fieldlabel): rename mod property referencing global token

A mod custom property was referencing a global token instead of the
component itself. Renames this and adds a note to the migration guide.

* feat(fieldlabel): use correct sizing tokens

Use correct tokens for some large and extra large custom properties,
to matching with design.

* style(fieldlabel): applying linter formatting adjustments

Run linter fix on the fieldlabel component, which rearranges a few
declarations.

* docs(fieldlabel): document asterisk icon size

Add documentation about asterisk UI icon sizes specified on the design.
These sizes are already handled in the Storybook template, but were not
really explained to the user.

* feat(fieldlabel): black and white static color variants

Add classes for static colors, as defined on the designs. And adds
examples of these variants to the documentation.

* build(fieldlabel): specify s2 tokens release for dependency

Use Spectrum 2 version of tokens package in dependencies list.
  • Loading branch information
jawinn authored and castastrophe committed Apr 18, 2024
1 parent 8a2437e commit 30de397
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5067,7 +5067,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "@spectrum-css/closebutton@workspace:components/closebutton"
dependencies:
"@spectrum-css/commons": "npm:^9.1.4-next.0"
"@spectrum-css/commons": "npm:^9.1.4-next.1"
peerDependencies:
"@spectrum-css/icon": ">=4"
"@spectrum-css/tokens": ^14.0.0-next.3
Expand Down Expand Up @@ -5188,6 +5188,15 @@ __metadata:
languageName: unknown
linkType: soft

"@spectrum-css/commons@npm:^9.1.4-next.1":
version: 9.1.4-next.1
resolution: "@spectrum-css/commons@npm:9.1.4-next.1"
peerDependencies:
"@spectrum-css/tokens": ^14.0.0-next.3
checksum: 10c0/2da6df7af8cbfc2fde1e243f6fb308fe89c8335c205965aab10939decb0d4a6446bbd51d81a89bcd4bb98a521f64efe0395fa28a098aaaadbe79d48fec9e1244
languageName: node
linkType: hard

"@spectrum-css/contextualhelp@workspace:components/contextualhelp":
version: 0.0.0-use.local
resolution: "@spectrum-css/contextualhelp@workspace:components/contextualhelp"
Expand Down

0 comments on commit 30de397

Please sign in to comment.