Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: data model for organizations #84

Merged
merged 21 commits into from
Jan 18, 2024
Merged

feat: data model for organizations #84

merged 21 commits into from
Jan 18, 2024

Conversation

alinarublea
Copy link
Contributor

@alinarublea alinarublea commented Jan 15, 2024

PR is WIP

  • unit test coverage
  • add more IT Tests

Copy link

This PR will trigger a minor release when merged.

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b16c366) 100.00% compared to head (e9cb3e9) 100.00%.
Report is 1 commits behind head on main.

❗ Current head e9cb3e9 differs from pull request most recent head c845417. Consider uploading reports for the commit c845417 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##              main       #84     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           21         9     -12     
  Lines         2011       573   -1438     
===========================================
- Hits          2011       573   -1438     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@solaris007 solaris007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just minor comments

@alinarublea alinarublea merged commit 944be83 into main Jan 18, 2024
3 checks passed
@alinarublea alinarublea deleted the SITES-17354 branch January 18, 2024 13:33
@solaris007
Copy link
Member

🎉 This PR is included in version @adobe/spacecat-shared-data-access-v1.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants