fix(sites-28856): update shared-data schema to include type in options #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* simplify condition
|
This PR will trigger a patch release when merged. |
solaris007
approved these changes
Feb 5, 2025
packages/spacecat-shared-data-access/src/models/import-job/import-job.schema.js
Outdated
Show resolved
Hide resolved
* include a data attribute on options
solaris007
approved these changes
Feb 6, 2025
packages/spacecat-shared-data-access/src/models/import-job/import-job.schema.js
Outdated
Show resolved
Hide resolved
added 2 commits
February 6, 2025 13:04
# Conflicts: # package-lock.json
solaris007
pushed a commit
that referenced
this pull request
Feb 6, 2025
# [@adobe/spacecat-shared-data-access-v2.1.1](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v2.1.0...@adobe/spacecat-shared-data-access-v2.1.1) (2025-02-06) ### Bug Fixes * **sites-28856:** update shared-data schema to include type in options ([#577](#577)) ([de6b670](de6b670))
|
🎉 This PR is included in version @adobe/spacecat-shared-data-access-v2.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To include support for crosswalk imports, we need to define
typeproperty in our options field. The value for type can either be 'xwalk' or 'doc'. The schema needs to be updated to support this new property.