Skip to content

feat: add multiple missing audit types #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 6, 2025
Merged

feat: add multiple missing audit types #575

merged 11 commits into from
Feb 6, 2025

Conversation

martinst06
Copy link
Contributor

Added missing audit types: sitemap, structured data, broken internal links, metatags, high organic low ctr (experimentation opportunities)

@martinst06 martinst06 self-assigned this Feb 5, 2025
Copy link

github-actions bot commented Feb 5, 2025

This PR will trigger a minor release when merged.

@martinst06 martinst06 requested a review from solaris007 February 5, 2025 15:29
Copy link
Member

@solaris007 solaris007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a test that checks:

  • all expected audit types are present
  • no unexpected audit types are present

@martinst06 martinst06 requested a review from solaris007 February 6, 2025 12:59
@martinst06 martinst06 requested a review from ekremney February 6, 2025 15:27
@martinst06 martinst06 changed the title feat: add multiple audit types feat: add multiple missing audit types Feb 6, 2025
@martinst06 martinst06 merged commit 48dcbee into main Feb 6, 2025
7 checks passed
@martinst06 martinst06 deleted the extend-audit-types branch February 6, 2025 16:14
solaris007 pushed a commit that referenced this pull request Feb 6, 2025
@solaris007
Copy link
Member

🎉 This PR is included in version @adobe/spacecat-shared-data-access-v2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants