Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rum api calls to shared #50

Merged
merged 12 commits into from
Dec 14, 2023
Merged

feat: add rum api calls to shared #50

merged 12 commits into from
Dec 14, 2023

Conversation

alinarublea
Copy link
Contributor

Please ensure your pull request adheres to the following guidelines:

  • make sure to link the related issues in this description
  • when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues

Thanks for contributing!

Copy link

This PR will trigger a minor release when merged.

Copy link
Member

@ekremney ekremney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also keep the docs in readme updated with the new methods

packages/spacecat-shared-rum-api-client/src/index.js Outdated Show resolved Hide resolved
packages/spacecat-shared-rum-api-client/src/index.js Outdated Show resolved Hide resolved
packages/spacecat-shared-rum-api-client/src/index.js Outdated Show resolved Hide resolved
@alinarublea alinarublea merged commit 56cccd0 into main Dec 14, 2023
3 checks passed
@alinarublea alinarublea deleted the rum-apis branch December 14, 2023 14:16
@solaris007
Copy link
Member

🎉 This PR is included in version @adobe/spacecat-shared-rum-api-client-v1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants