Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SITES-25634 [Importer] Expose hasCustomImportJs and hasCustomHeaders as two new fields on a import job #381

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

bhellema
Copy link
Contributor

No description provided.

Ben Helleman added 2 commits September 23, 2024 16:43
…ders as two new fields on a import job.

* hasCustomHeaders and hasCustomImportJs are optional, and default to false
@bhellema bhellema added the enhancement New feature or request label Sep 24, 2024
@bhellema bhellema self-assigned this Sep 24, 2024
Copy link
Contributor

@blefebvre blefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like changes will have to follow on the api-service side to set these props correctly — right?

@bhellema
Copy link
Contributor Author

Looks like changes will have to follow on the api-service side to set these props correctly — right?

Correct: adobe/spacecat-api-service#509

Copy link

This PR will trigger a patch release when merged.

@bhellema bhellema merged commit b90a7c5 into main Sep 24, 2024
9 checks passed
@bhellema bhellema deleted the bhellema/SITES-25634 branch September 24, 2024 18:30
adobe-bot pushed a commit that referenced this pull request Sep 24, 2024
# [@adobe/spacecat-shared-data-access-v1.45.1](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v1.45.0...@adobe/spacecat-shared-data-access-v1.45.1) (2024-09-24)

### Bug Fixes

* SITES-25634 [Importer] Expose hasCustomImportJs and hasCustomHeaders as two new fields on a import job ([#381](#381)) ([b90a7c5](b90a7c5))
@adobe-bot
Copy link

🎉 This issue has been resolved in version @adobe/spacecat-shared-data-access-v1.45.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants