Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Importer] Specify the list of supported features #356

Closed
wants to merge 4 commits into from

Conversation

bhellema
Copy link
Contributor

@bhellema bhellema commented Sep 3, 2024

Fixing up some documentation, and define a constant to specify what features the importer supports.

Related Issues

SITES-24836

@bhellema bhellema force-pushed the bhellema/SITES-24836 branch from 2f22fae to 8d0893f Compare September 4, 2024 12:47
Copy link

github-actions bot commented Sep 4, 2024

This PR will trigger a patch release when merged.

@bhellema bhellema force-pushed the bhellema/SITES-24836 branch from 8d0893f to f6c8480 Compare September 4, 2024 12:47
Copy link
Contributor

@swetabar swetabar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Ben! Thanks for the validation checks~
I added a few comments / questions.

@bhellema bhellema force-pushed the bhellema/SITES-24836 branch from f6c8480 to 3bf2b92 Compare September 5, 2024 15:22
@bhellema bhellema force-pushed the bhellema/SITES-24836 branch from 3bf2b92 to 12f8929 Compare September 5, 2024 15:22
@bhellema bhellema self-assigned this Sep 5, 2024
@bhellema bhellema added the enhancement New feature or request label Sep 5, 2024
Copy link
Contributor

@blefebvre blefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have the import options validation in place. Few comments to consider.

@bhellema bhellema closed this Sep 9, 2024
@bhellema bhellema deleted the bhellema/SITES-24836 branch September 9, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants