-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [Importer] Specify the list of supported features #356
Conversation
2f22fae
to
8d0893f
Compare
This PR will trigger a patch release when merged. |
8d0893f
to
f6c8480
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, Ben! Thanks for the validation checks~
I added a few comments / questions.
packages/spacecat-shared-data-access/src/models/importer/import-job.js
Outdated
Show resolved
Hide resolved
f6c8480
to
3bf2b92
Compare
3bf2b92
to
12f8929
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to have the import options validation in place. Few comments to consider.
packages/spacecat-shared-data-access/src/service/import-job/accessPatterns.js
Show resolved
Hide resolved
packages/spacecat-shared-data-access/src/service/import-job/accessPatterns.js
Show resolved
Hide resolved
Co-authored-by: Bruce Lefebvre <[email protected]>
Co-authored-by: Bruce Lefebvre <[email protected]>
Co-authored-by: Bruce Lefebvre <[email protected]>
Fixing up some documentation, and define a constant to specify what features the importer supports.
Related Issues
SITES-24836