Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add property to include specific urls in the site config #343

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

dzehnder
Copy link
Contributor

Upon several naming discussions, we decided to change the name from product detail pages so something more generic.

@dzehnder dzehnder added the bug Something isn't working label Aug 22, 2024
@dzehnder dzehnder self-assigned this Aug 22, 2024
Copy link
Contributor

@iuliag iuliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻
No test needs to change when renaming this property?

@dzehnder
Copy link
Contributor Author

👍🏻 No test needs to change when renaming this property?

the change is tested via the config schema

@dzehnder dzehnder merged commit 184107a into main Aug 22, 2024
9 checks passed
@dzehnder dzehnder deleted the generify-pdp-to-include-urls branch August 22, 2024 15:27
adobe-bot pushed a commit that referenced this pull request Aug 22, 2024
# [@adobe/spacecat-shared-data-access-v1.43.2](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v1.43.1...@adobe/spacecat-shared-data-access-v1.43.2) (2024-08-22)

### Bug Fixes

* add property to include specific urls in the site config ([#343](#343)) ([184107a](184107a))
@adobe-bot
Copy link

🎉 This issue has been resolved in version @adobe/spacecat-shared-data-access-v1.43.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants