test: fix updatedAt test #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, the test failed with assertion error, because it compared expected with passed updatedAt on a new record (no id), whereas for new records a updatedAt is generated in the constructor. ``` AssertionError: expected '2024-01-18T16:23:59.276Z' to equal '2024-01-18T16:23:59.275Z' ```
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #119 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 2588 2595 +7
=========================================
+ Hits 2588 2595 +7 ☔ View full report in Codecov by Sentry. |
solaris007
approved these changes
Jan 30, 2024
dzehnder
approved these changes
Jan 30, 2024
|
🎉 This PR is included in version @adobe/spacecat-shared-data-access-v1.13.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, the test failed with assertion error, because it compared expected with passed
updatedAton a new record (no id), whereas for new records anupdatedAtis generated in the constructor.