chore: feedback

adobe · Aug 23, 2024 · a8bf378 · a8bf378
1 parent a7d60e2
commit a8bf378
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 13 deletions.
diff --git a/packages/spacecat-shared-content-client/src/clients/content-client.js b/packages/spacecat-shared-content-client/src/clients/content-client.js
@@ -51,19 +51,19 @@ const validateConfiguration = (config, contentSourceType) => {
     }
   }
 };
+
 const validateSite = (site) => {
   if (!isObject(site)) {
     throw new Error('Site is required');
   }
 
-  const siteConfig = site.getConfig();
-  if (!isObject(siteConfig?.content?.source)) {
-    throw new Error('Site must have a content source');
+  const contentSource = site.getConfig()?.content?.source;
+  if (!isObject(contentSource)) {
+    throw new Error('Site must have a valid content source');
   }
 
-  const contentSourceType = siteConfig.content.source.type;
-  if (!SUPPORTED_CONTENT_SOURCES.has(contentSourceType)) {
-    throw new Error(`Unsupported content source type: ${contentSourceType}`);
+  if (!SUPPORTED_CONTENT_SOURCES.has(contentSource.type)) {
+    throw new Error(`Unsupported content source type: ${contentSource.type}`);
   }
 };
 
@@ -131,14 +131,10 @@ export default class ContentClient {
   }
 
   #resolveDocPath(path) {
-    let docPath = path;
-
-    if (path.endsWith('/')) {
-      docPath = `${path}index`;
-    }
+    let docPath = path.endsWith('/') ? `${path}index` : path;
 
     if (this.contentSource.type === CONTENT_SOURCE_TYPE_ONEDRIVE) {
-      docPath = `${docPath}.docx`;
+      docPath += '.docx';
     }
 
     return docPath;

diff --git a/packages/spacecat-shared-content-client/test/clients/content-client.test.js b/packages/spacecat-shared-content-client/test/clients/content-client.test.js
@@ -112,7 +112,7 @@ describe('ContentClient', () => {
 
     it('throws an error if site has no content source', () => {
       const invalidSite = { getConfig: () => ({ }) };
-      expect(() => new ContentClient(env, invalidSite, log)).to.throw('Site must have a content source');
+      expect(() => new ContentClient(env, invalidSite, log)).to.throw('Site must have a valid content source');
     });
 
     it('throws an error if site\'s content source type is unsupported', () => {