fix: pr reviews

adobe · Jan 24, 2024 · a825493 · a825493
1 parent 5f83825
commit a825493
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 7 deletions.
diff --git a/packages/spacecat-shared-slack-client/README.md b/packages/spacecat-shared-slack-client/README.md
@@ -5,7 +5,7 @@ A library utility to manage to interact with different Slack organizations.
 ## Installation
 
 ```
-npm install my-slack-client
+npm install @adobe/spacecat-shared-slack-client
 ```
 
 ## Usage
@@ -60,6 +60,7 @@ const threadId = 'thread-id'; // thread id to send the message under (optional)
 // initializations...
 
 await slackClient.postMessage(ADOBE_INTERNAL, {
+  text: 'HELLO WORLD!',
   channel: 'channel-id',
   thread_ts: threadId, // (optional)
 });

diff --git a/packages/spacecat-shared-slack-client/src/index.js b/packages/spacecat-shared-slack-client/src/index.js
@@ -23,11 +23,16 @@ const DEFAULT_PARAMS = {
   unfurl_media: false,
 };
 
+function getEnvironmentVariableNameForTarget(target) {
+  return `${ENV_PREFIX}${target}`;
+}
+
 export class SlackClient {
   static createFrom(context) {
     if (context.slackClient) return context.slackClient;
 
-    const expected = Object.values(SLACK_TARGETS).map((target) => `${ENV_PREFIX}${target}`);
+    const expected = Object.values(SLACK_TARGETS)
+      .map((target) => getEnvironmentVariableNameForTarget(target));
 
     const targetTokenPairs = Object.keys(context.env)
       .filter((variable) => expected.includes(variable))
@@ -51,16 +56,16 @@ export class SlackClient {
     }
 
     this.clients = targetTokenPairs
-      .reduce((acc, pair) => {
-        acc[pair.target] = new WebClient(pair.token);
+      .reduce((acc, { target, token }) => {
+        acc[target] = new WebClient(token);
         return acc;
       }, {});
     this.log = log;
   }
 
   #getClient(target) {
     if (!this.clients[target]) {
-      throw new Error(`Environment variable '${ENV_PREFIX}${target}' does not exist. Slack Client could not initialized.`);
+      throw new Error(`Environment variable '${getEnvironmentVariableNameForTarget(target)}' does not exist. Slack Client could not be initialized.`);
     }
     return this.clients[target];
   }
@@ -78,7 +83,7 @@ export class SlackClient {
         threadId: result.ts,
       };
     } catch (error) {
-      this.log.error(`Slack message failed to send to ${target}`);
+      this.log.error(`Slack message failed to send to ${target}`, error);
       throw error;
     }
   }

diff --git a/packages/spacecat-shared-slack-client/test/index.test.js b/packages/spacecat-shared-slack-client/test/index.test.js
@@ -64,7 +64,7 @@ describe('Slack Client', () => {
       },
     });
     await expect(slackClient.postMessage('unknown-target', {}))
-      .to.be.rejectedWith('Environment variable \'SLACK_TOKEN_unknown-target\' does not exist. Slack Client could not initialized.');
+      .to.be.rejectedWith('Environment variable \'SLACK_TOKEN_unknown-target\' does not exist. Slack Client could not be initialized.');
   });
 
   it('returns channel-id and thread-id when message posted', async () => {