fix: use domain key for rum sources query

packages/spacecat-shared-rum-api-client/src/index.d.ts

@@ -116,9 +116,10 @@ export default class RUMAPIClient {
    * Method to return the url composed of params that the 404 sources API is called with.
    * @param {RUMAPIOptions} params - An object representing the parameters to be included
    *  for the 404 sources API call.
-   * @returns A string returning to the 404 sources url including query parameters.
+   * @returns A promise that resolves a string returning the 404
+   * sources url including query parameters.
    */
-  create404URL(params?: RUMAPIOptions): string;
+  create404URL(params?: RUMAPIOptions): Promise<string>;
 
   /**
    * Asynchronous method to return an array with the domain for a specific url

packages/spacecat-shared-rum-api-client/src/index.js

@@ -123,11 +123,12 @@ export default class RUMAPIClient {
     this.domainkey = domainkey;
   }
 
-  create404URL(params = {}) {
+  async create404URL(params = {}) {
+    const scopedDomainKey = await generateDomainKey(this.domainkey, params?.url, 7);
     return createUrl(
       APIS.RUM_SOURCES,
       {
-        domainkey: this.domainkey, ...NOT_FOUND_DEFAULT_PARAMS, ...params,
+        domainkey: scopedDomainKey, ...NOT_FOUND_DEFAULT_PARAMS, ...params,
       },
     );
   }
@@ -159,7 +160,8 @@ export default class RUMAPIClient {
   }
 
   async get404Sources(params = {}) {
-    return sendRequest(this.create404URL(params));
+    const notFoundURL = await this.create404URL(params);
+    return sendRequest(notFoundURL);
   }
 
   async getDomainList(params = {}) {

packages/spacecat-shared-rum-api-client/test/rum-api-client.test.js

@@ -15,6 +15,7 @@ import chai from 'chai';
 import chaiAsPromised from 'chai-as-promised';
 import nock from 'nock';
 import RUMAPIClient, { sendRequest } from '../src/index.js';
+import { successKeyResponse } from './rumapi-data.js';
 
 chai.use(chaiAsPromised);
 const { expect } = chai;
@@ -91,10 +92,14 @@ describe('rum api client', () => {
       }]);
   });
 
-  it('returns the URL to call the get404Sources', () => {
+  it('returns the URL to call the get404Sources', async () => {
     const rumApiClient = RUMAPIClient.createFrom({ env: { RUM_DOMAIN_KEY: 'hebele' } });
-    expect(rumApiClient.create404URL({ url: 'http://spacecar.com' }))
-      .to.eql('https://helix-pages.anywhere.run/helix-services/run-query@v3/rum-sources?domainkey=hebele&interval=7&offset=0&limit=101&checkpoint=404&url=http%3A%2F%2Fspacecar.com');
+    nock('https://helix-pages.anywhere.run')
+      .post('/helix-services/run-query@v3/rotate-domainkeys')
+      .query(true)
+      .reply(200, successKeyResponse);
+    await expect(rumApiClient.create404URL({ url: 'http://spacecar.com' }))
+      .to.eventually.eql('https://helix-pages.anywhere.run/helix-services/run-query@v3/rum-sources?domainkey=scoped-domain-key&interval=7&offset=0&limit=101&checkpoint=404&url=http%3A%2F%2Fspacecar.com');
   });
 
   it('returns the URL to call the getRUMDashboard', () => {
@@ -104,18 +109,23 @@ describe('rum api client', () => {
   });
 
   it('returns data when get404Sources api is successful', async () => {
+    nock('https://helix-pages.anywhere.run')
+      .post('/helix-services/run-query@v3/rotate-domainkeys')
+      .query(true)
+      .reply(200, successKeyResponse);
     nock('https://helix-pages.anywhere.run/helix-services')
       .get('/run-query@v3/rum-sources')
       .query({
-        domainkey: 'hebele',
+        domainkey: 'scoped-domain-key',
+        url: 'spacecar.com',
         interval: 7,
         offset: 0,
         limit: 101,
         checkpoint: 404,
       })
       .reply(200, JSON.stringify({ results: { data: [{ url: 'http://spacecar.com', views: 100, sources: 'www.google.com' }] } }));
     const rumApiClient = RUMAPIClient.createFrom({ env: { RUM_DOMAIN_KEY: 'hebele' } });
-    await expect(rumApiClient.get404Sources())
+    await expect(rumApiClient.get404Sources({ url: 'spacecar.com' }))
       .to.eventually.eql([{ url: 'http://spacecar.com', views: 100, sources: 'www.google.com' }]);
   });