fix(sites-28856): update shared-data schema to include type in options

adobe · Feb 6, 2025 · 3dd778e · 3dd778e
1 parent 1c5c511
commit 3dd778e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/packages/spacecat-shared-data-access/src/models/import-job/import-job.schema.js b/packages/spacecat-shared-data-access/src/models/import-job/import-job.schema.js
@@ -15,6 +15,7 @@
 import {
   isInteger,
   isIsoDate,
+  isNonEmptyObject,
   isNumber,
   isObject,
   isValidUrl,
@@ -41,7 +42,7 @@ const ImportOptionTypeValidator = {
     }
   },
   [ImportJob.ImportOptions.DATA]: (value) => {
-    if (!isObject(value)) {
+    if (value && !isNonEmptyObject(value)) {
       throw new Error(`Invalid value for ${ImportJob.ImportOptions.DATA}: ${value}`);
     }
   },

diff --git a/packages/spacecat-shared-data-access/test/it/import-job/import-job.test.js b/packages/spacecat-shared-data-access/test/it/import-job/import-job.test.js
@@ -108,6 +108,14 @@ describe('ImportJob IT', async () => {
       expect(err.cause).to.be.instanceOf(ElectroValidationError);
       expect(err.cause.message).to.contain('Invalid value for data: not-an-object');
     });
+
+    // test to make sure data is not an empty object
+    data = { ...newJobData, options: { data: { } } };
+    await ImportJob.create(data).catch((err) => {
+      expect(err).to.be.instanceOf(DataAccessError);
+      expect(err.cause).to.be.instanceOf(ElectroValidationError);
+      expect(err.cause.message).to.contain('Invalid value for data');
+    });
   });
 
   it('throws an error when adding a new import job with invalid options', async () => {