fix: add validation check for import job id

adobe · Sep 16, 2024 · 0f974a7 · 0f974a7
1 parent 0362ba4
commit 0f974a7
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 11 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/spacecat-shared-data-access/src/models/importer/import-url.js b/packages/spacecat-shared-data-access/src/models/importer/import-url.js
@@ -105,6 +105,10 @@ export const createImportUrl = (data) => {
     throw new Error(`Invalid Url: ${newState.url}`);
   }
 
+  if (!hasText(newState.jobId)) {
+    throw new Error(`Invalid Job ID: ${newState.jobId}`);
+  }
+
   if (!Object.values(ImportUrlStatus).includes(newState.status)) {
     throw new Error(`Invalid Import URL status: ${newState.status}`);
   }

diff --git a/packages/spacecat-shared-data-access/test/unit/models/importer/import-url.test.js b/packages/spacecat-shared-data-access/test/unit/models/importer/import-url.test.js
@@ -42,6 +42,10 @@ describe('ImportUrl Model tests', () => {
     it('throws an error if status is invalid', () => {
       expect(() => createImportUrl({ ...validImportUrlData, status: 'invalid' })).to.throw('Invalid Import URL status: invalid');
     });
+
+    it('throws an error if jobId is not a valid string', () => {
+      expect(() => createImportUrl({ ...validImportUrlData, jobId: null })).to.throw('Invalid Job ID: null');
+    });
   });
   describe('Import URL Functionality Tests', () => {
     let importUrl;