Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: same domain check with www for baseUrl #375

Merged
merged 4 commits into from
Aug 23, 2024

Conversation

AndreiAlexandruParaschiv
Copy link
Contributor

@AndreiAlexandruParaschiv AndreiAlexandruParaschiv commented Aug 22, 2024

Small fix for the usecase :

  • when url.hostname has www but base.hostname doesn't.
    www.example.com vs example.com

Copy link

This PR will trigger a patch release when merged.

@AndreiAlexandruParaschiv AndreiAlexandruParaschiv merged commit eb30da3 into main Aug 23, 2024
4 checks passed
@AndreiAlexandruParaschiv AndreiAlexandruParaschiv deleted the canonicaldomain branch August 23, 2024 16:20
solaris007 pushed a commit that referenced this pull request Aug 23, 2024
## [1.26.4](v1.26.3...v1.26.4) (2024-08-23)

### Bug Fixes

* same domain check with www for baseUrl ([#375](#375)) ([eb30da3](eb30da3))
@solaris007
Copy link
Member

🎉 This PR is included in version 1.26.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants