Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce structured data audit #367

Merged
merged 26 commits into from
Aug 27, 2024
Merged

feat: introduce structured data audit #367

merged 26 commits into from
Aug 27, 2024

Conversation

dzehnder
Copy link
Contributor

@dzehnder dzehnder commented Aug 19, 2024

This PR implements the audit for SITES-24087: Audit: structured data

@ekremney
Copy link
Member

ekremney commented Aug 19, 2024

Wouldn't "GSC - rich results audit" be a better name for this audit? I see that it only audits the rich results in the GSC result. PDPs have many more indexability issues. Those issues stem from different factors which may also affect non ecommerce sites.

package.json Outdated Show resolved Hide resolved
src/url-inspect/pdp-handler.js Outdated Show resolved Hide resolved
src/url-inspect/pdp-handler.js Outdated Show resolved Hide resolved
@solaris007 solaris007 added the enhancement New feature or request label Aug 20, 2024
Copy link

This PR will trigger a minor release when merged.

Copy link
Contributor

@iuliag iuliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To my understanding: this is a structured-data or indexability audit, that's the concept.

The audit result includes both:

  • indexability flag
  • rich results issues, that are not only PDP specific (you don't filter by schemas specific to PDPs only).

GSC, URL inspect, PDP are just implementation details.

src/index.js Outdated Show resolved Hide resolved
src/url-inspect/pdp-handler.js Outdated Show resolved Hide resolved
src/url-inspect/pdp-handler.js Outdated Show resolved Hide resolved
test/audits/pdp.test.js Outdated Show resolved Hide resolved
@dzehnder dzehnder changed the title feat: introduce indexability audit for e-commerce URLs feat: introduce structured data audit Aug 22, 2024
# Conflicts:
#	package-lock.json
#	package.json
# Conflicts:
#	package-lock.json
#	package.json
@dzehnder dzehnder merged commit 3e6901d into main Aug 27, 2024
4 checks passed
@dzehnder dzehnder deleted the url-inspect branch August 27, 2024 09:15
solaris007 pushed a commit that referenced this pull request Aug 27, 2024
# [1.29.0](v1.28.1...v1.29.0) (2024-08-27)

### Features

* introduce structured data audit ([#367](#367)) ([3e6901d](3e6901d))
@solaris007
Copy link
Member

🎉 This PR is included in version 1.29.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants