Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: canonical url audit #326

Merged
merged 84 commits into from
Aug 14, 2024
Merged

feat: canonical url audit #326

merged 84 commits into from
Aug 14, 2024

Conversation

AndreiAlexandruParaschiv
Copy link
Contributor

@AndreiAlexandruParaschiv AndreiAlexandruParaschiv commented Jul 19, 2024 •
edited
Loading

Ticket : https://jira.corp.adobe.com/browse/SITES-18823

Canonical Audit

  • gets 200 top url pages from DB
  • each url page is verified against diverse canonical checks
  • output results
"auditResult": {
           "canonical-url-lowercased": {
			"success": true,
			"url": [
			"https://example.com",
                                  ...]
                           },
            "canonical-url-same-protocol": {
                        "success": false,
			"url": [
			"https://example.com/testPage",
                                  ...]
                            }
                   ...
            ]

Get canonical results: {{ Spacecat_dev }}/{siteId}/latest-audit/canonical

@AndreiAlexandruParaschiv AndreiAlexandruParaschiv added enhancement New feature or request WIP work in progress labels Jul 19, 2024
@github-actions GitHub Actions
Copy link

This PR will trigger a minor release when merged.

@AndreiAlexandruParaschiv AndreiAlexandruParaschiv mentioned this pull request Jul 29, 2024
Merged
@AndreiAlexandruParaschiv AndreiAlexandruParaschiv marked this pull request as ready for review July 30, 2024 09:55
@AndreiAlexandruParaschiv AndreiAlexandruParaschiv removed the WIP work in progress label Aug 8, 2024
@iuliag iuliag mentioned this pull request Aug 12, 2024
Open
iuliag
iuliag approved these changes Aug 13, 2024
View reviewed changes
src/canonical/handler.js Show resolved Hide resolved
test/audits/canonical.test.js Show resolved Hide resolved
src/canonical/handler.js Outdated Show resolved Hide resolved
@AndreiAlexandruParaschiv AndreiAlexandruParaschiv mentioned this pull request Aug 14, 2024
Closed
@AndreiAlexandruParaschiv AndreiAlexandruParaschiv merged commit 86692c8 into main Aug 14, 2024
4 checks passed
solaris007 pushed a commit that referenced this pull request Aug 14, 2024
@semantic-release-bot
chore(release): 1.25.0 [skip ci]
a947a7a 
# [1.25.0](v1.24.0...v1.25.0) (2024-08-14)

### Features

* canonical url audit ([#326](#326)) ([86692c8](86692c8))
@solaris007
Copy link
Member

🎉 This PR is included in version 1.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuliag iuliag iuliag approved these changes

@ekremney ekremney Awaiting requested review from ekremney

@alinarublea alinarublea Awaiting requested review from alinarublea

@solaris007 solaris007 Awaiting requested review from solaris007

@dzehnder dzehnder Awaiting requested review from dzehnder

Assignees

@AndreiAlexandruParaschiv AndreiAlexandruParaschiv

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndreiAlexandruParaschiv @solaris007 @iuliag @dzehnder