fix: use allSettled

adobe · Aug 20, 2024 · ff9c383 · ff9c383
1 parent bf38c3a
commit ff9c383
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/backlinks/handler.js b/src/backlinks/handler.js
@@ -19,8 +19,8 @@ import { retrieveSiteBySiteId } from '../utils/data-access.js';
 import { enhanceBacklinksWithFixes, isStillBrokenURL } from '../support/utils.js';
 
 export async function filterOutValidBacklinks(backlinks, log) {
-  const backlinkStatuses = await Promise.all(backlinks.map(async (backlink) => isStillBrokenURL(backlink.url_to, 'backlink', log)));
-  return backlinks.filter((_, index) => backlinkStatuses[index]);
+  const backlinkStatuses = await Promise.allSettled(backlinks.map(async (backlink) => isStillBrokenURL(backlink.url_to, 'Backlink', log)));
+  return backlinks.filter((_, index) => backlinkStatuses[index].status === 'fulfilled' && backlinkStatuses[index].value);
 }
 
 export default async function auditBrokenBacklinks(message, context) {

diff --git a/test/audits/backlinks.test.js b/test/audits/backlinks.test.js
@@ -27,7 +27,6 @@ import auditBrokenBacklinks from '../../src/backlinks/handler.js';
 use(sinonChai);
 use(chaiAsPromised);
 
-// eslint-disable-next-line func-names
 describe('Backlinks Tests', function () {
   this.timeout(10000);
   let message;
@@ -512,7 +511,7 @@ describe('Backlinks Tests', function () {
     expect(context.sqs.sendMessage).to.have.been.calledOnce;
     expect(context.sqs.sendMessage).to.have.been
       .calledWith(context.env.AUDIT_RESULTS_QUEUE_URL, expectedMessage);
-    expect(context.log.warn).to.have.been.calledWith('backlink https://foo.com/returns-429 returned status 429');
+    expect(context.log.warn).to.have.been.calledWith('Backlink https://foo.com/returns-429 returned status 429');
     expect(context.log.info).to.have.been.calledWith('Successfully audited site2 for broken-backlinks type audit');
   });