fix: unexpected close tag issue

adobe · Aug 20, 2024 · 537a6ac · 537a6ac
1 parent 4fac879
commit 537a6ac
Showing 1 changed file with 14 additions and 10 deletions.
diff --git a/src/sitemap/handler.js b/src/sitemap/handler.js
@@ -138,32 +138,36 @@ export function isSitemapContentValid(sitemapContent) {
 export async function checkSitemap(sitemapUrl, log) {
   try {
     const sitemapContent = await fetchContent(sitemapUrl, log);
-    const isValidFormat = isSitemapContentValid(sitemapContent);
-    const isSitemapIndex = isValidFormat && sitemapContent.payload.includes('</sitemapindex>');
-    const isText = isValidFormat && sitemapContent.type === 'text/plain';
+    if (!sitemapContent || !sitemapContent.payload) {
+      log.error(`No content received from ${sitemapUrl}`);
+      return {
+        existsAndIsValid: false,
+        reasons: [ERROR_CODES.SITEMAP_NOT_FOUND],
+        details: { sitemapContent: {}, isText: false, isSitemapIndex: false },
+      };
+    }
 
+    const isValidFormat = isSitemapContentValid(sitemapContent);
     if (!isValidFormat) {
+      log.error(`Invalid sitemap format at ${sitemapUrl}`);
       return {
         existsAndIsValid: false,
         reasons: [ERROR_CODES.SITEMAP_FORMAT],
         details: { sitemapContent: {}, isText: false, isSitemapIndex: false },
       };
     }
 
+    const isSitemapIndex = sitemapContent.payload.includes('</sitemapindex>');
+    const isText = sitemapContent.type === 'text/plain';
+
     log.info(`Processed ${sitemapUrl}: isSitemapIndex=${isSitemapIndex}`);
     return {
       existsAndIsValid: true,
       reasons: [],
       details: { sitemapContent, isText, isSitemapIndex },
     };
   } catch (error) {
-    if (error.message.includes('404')) {
-      return {
-        existsAndIsValid: false,
-        reasons: [ERROR_CODES.SITEMAP_NOT_FOUND],
-        details: { sitemapContent: {}, isText: false, isSitemapIndex: false },
-      };
-    }
+    log.error(`Error processing sitemap at ${sitemapUrl}: ${error.message}`);
     return {
       existsAndIsValid: false,
       reasons: [ERROR_CODES.FETCH_ERROR],