Have option to specify gitops path where to place generated files

[arturo-skydio]

Description

Currently, gitops files get generated under a hardcoded prefix path of cloud, need a way to have a variable input for this

Related Issue

#60

Motivation and Context

For repositories that do not want gitops files generated at cloud path, this change is needed

How Has This Been Tested?

Just started using this and verified that no gitops_path renders gitops files in usual cloud directory, while specifying path correctly changes the prefix path

Types of changes

• New feature (non-breaking change which adds functionality)

Checklist:

• I have signed the Adobe Open Source CLA.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[michaelschiff]

@arturo-skydio thank you for the contribution! mind signing the CLA?

[arturo-skydio]

@arturo-skydio thank you for the contribution! mind signing the CLA?

@michaelschiff I thought I did,
not sure if its because the change comes from our skydio org, maybe I should just try to open the PR from my gh account?

[arturo-skydio]

@michaelschiff sorry, was a bit impatient with opening up the other PR, looks like the CLA is green now, thanks

[kzadorozhny]

Looks good overall. No issue with the change. But there are couple issues that need to be addressed before we can merge:

• You might want to add another test case into the e2e_test. Right now we rely on cloud directory being default. For example you can add another k8s_deploy target alongside release and canary targets and update the script. Don't forget to update the .gitignore file too.
• cloud also is hardcoded in couple places ( 1, 2 ) in the GitOps PRs tool.

[arturo-skydio]

Looks good overall. No issue with the change. But there are couple issues that need to be addressed before we can merge:

• You might want to add another test case into the e2e_test. Right now we rely on cloud directory being default. For example you can add another k8s_deploy target alongside release and canary targets and update the script. Don't forget to update the .gitignore file too.
• cloud also is hardcoded in couple places ( 1, 2 ) in the GitOps PRs tool.

Sounds good, thanks for taking a look, I'll add the test

[arturo-skydio]

@kzadorozhny Added a test for gitops_path and made sure to remove hardcoding in the Gitops Prs tool, let me know if all look good, thanks again

[kzadorozhny]

Overall LGTM. Please address one comment and I'll merge it.