fix: prevent menu item focus ring from exceeding popover boundaries #7672
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuiliao
changed the title
snowystinger
previously approved these changes
Jan 28, 2025
snowystinger
approved these changes
Jan 30, 2025
| @@ -79,6 +79,7 @@ let popover = style({ | |||
| // Don't be larger than full screen minus 2 * containerPadding | |||
| maxWidth: '[calc(100vw - 24px)]', | |||
| boxSizing: 'border-box', | |||
| display: 'flex', | |||
There was a problem hiding this comment.
possibly problematic, may affect how children are rendered, or is the child always something predictable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/orgs/adobe/projects/19/views/4?pane=issue&itemId=90609300 for an example
This happens not just with focus rings. Try with any component that uses a popover on main, make sure that scrolling appears by adjusting the height of the viewable area, and then see how items on the bottom will appear before they're actually on the popover.
chromatic: https://www.chromatic.com/build?appId=5f0dd5ad2b5fc10022a2e320&number=882
✅ Pull Request Checklist:
📝 Test Instructions:
Try components like S2 Menu, Picker, Popover, Combobox, to make sure items and focus rings do not exceed the popover's borders.
🧢 Your Project: