Decrease timeouts in test utils #7102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reidbarber
previously approved these changes
Sep 27, 2024
devongovett
dismissed
reidbarber’s stale review
The merge-base changed after approval.
snowystinger
force-pushed
the
decrease-timeouts-in-test-utils
branch
from
12fadd3
to
17dba4a
Compare
devongovett
approved these changes
Oct 15, 2024
ktabors
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
100 items was causing multiple interactions to take almost half a second to process. This is not accurate to real life as we have no virtualization in those tests.
In addition, we no longer have transitions on tables, so can remove the timeout for that in our test util. We can add it back in conditionally if we end up needing it.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: