DatePicker with defaultValue persists time zone #7069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* testing theme change and webkit-highlight-color change * Fix iOS tap highlight * moving webkit highlight to theme * forgot to remove extra tsignore
* css rename to styles * fix comment
* fix SearchFieldProps children type * remove isEntering and isExiting from TooltipProps * omit more props from Tooltip * remove open props from Tooltip Co-authored-by: Reid Barber <[email protected]>
* setup storybook docs * add intro page * Remove Picker autodocs * add syntax highlighting to code snippet * add missing autodocs * Remove intro docs for now * remove extra args from Dialog * clean up source formatting Co-authored-by: Reid Barber <[email protected]> Co-authored-by: Rob Snow <[email protected]>
Co-authored-by: Devon Govett <[email protected]>
* starting a rollup add to test the built files * rainbow and macros installed and working Co-authored-by: Kyle Taborski <[email protected]>
* Add vite example * Add svgs and fix config
Co-authored-by: Kyle Taborski <[email protected]>
Co-authored-by: Kyle Taborski <[email protected]>
…e for invalid validation (adobe#115) * revert Field change when invalid * Update Modal and Popover so corner with scrollbar is square
* update css prop in InlineAlert * add webpack 5 example * remove Provider * use render from react-dom * add gitignore * cleanup package.json * fix React import * add icon to button Co-authored-by: Reid Barber <[email protected]>
* add menu and actionmenu * fix stories for actionbutton and checkboxgroup * fix actionbutton resizing story * Remove styles prop from code output * remove handlers from code output * add // code: null to config * fix StaticColorDecorator * cleanup * improve dialog example * add global padding to stories * remove css file * remove role from DialogProps type * improve ActionButton story * use single quotes for jsdoc @default * cleanup Dialog stories and code output Co-authored-by: Reid Barber <[email protected]>
* add storybook logo * Use italics for tagline Co-authored-by: Reid Barber <[email protected]>
* fix show code button z-index * fix to use isolation: isolate instead Co-authored-by: Reid Barber <[email protected]>
Co-authored-by: Yihui Liao <[email protected]>
Co-authored-by: Kyle Taborski <[email protected]>
* Fix chromatic publish to storybook this prevents the Intro page from being sent to Chromatic, looks like it causes issues for them * Update change so it is isolated to chromatic run
snowystinger
previously approved these changes
Sep 26, 2024
|
Looks like you might need to sign the CLA? https://react-spectrum.adobe.com/contribute.html#contributor-license-agreement |
* pass through disabledKeys to ActionGroup * fix linting issues --------- Co-authored-by: Grant Russell <[email protected]>
* add s2 components to Parcel app * add components to Webpack example * add to verdaccio build * build verdaccio on branch * try adding yarn config * fix yarn * add build script to parcel all * typo in path * enable comment on PR * comment on PR * try removing typekits * update webpack render to createRoot * try removing TagGroup * remove TagGroup from example apps * add branch filters back * update example app S2 versions to be "latest" * add TagGroup back * remove branch filters * Revert "remove branch filters" This reverts commit b7b54fe. * Fix style publishing * turn on verdaccio * Revert "turn on verdaccio" This reverts commit 3be5f9c. --------- Co-authored-by: GitHub <[email protected]>
* Fix ComboBox and Picker getting stuck in down state * Fix table types and export from package
|
@snowystinger thanks for the review, I have just signed the CLA. |
|
Thank, I'll close and reopen as it looks like it's stuck at the moment. |
* Remove extraneous hover props from s2 * Fix ts * use the correct prop name
* S2 Table optimizations * fix merge
* Add some missing docs descriptions * Rename strange interface in props * Fix sizes of pending button spinner * Add docs for --tree-item-level custom property in Tree * fix ts * Require children for disclosures * Make it so Accordion isn't labellable * fix button typescript * narrow test utils exports and future proof * Remove isPending from ActionButton --------- Co-authored-by: Robert Snow <[email protected]> Co-authored-by: GitHub <[email protected]>
* disable snapshot for regular stories, remove s2 from title * add chromatic stories from missing components * fix lint * add more chromatic stories for missing components and remove s2 prefix * remove disable snapshot, update chromatic-fc * Some docs improvements --------- Co-authored-by: Devon Govett <[email protected]>
* S2 chromatic table * fix cardview chromatic stories
* Export pressScale and focusRing utilities from S2 * Also export StyleString type
* Rename SegmentedControl props to match selection APIs * fix chromatic stories * ts strict * Add AriaLabelingProps * Pass value and defaultValue to RadioGroup * fix merge conflicts
* add disclosure tests * lint/cleanup * Pass isExpanded to useDisclosure as well --------- Co-authored-by: Robert Snow <[email protected]> Co-authored-by: Devon Govett <[email protected]>
|
trying again to get it unstuck |
devongovett
dismissed
snowystinger’s stale review
The merge-base changed after approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6005
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: