Skip to content

fix: correct scrollable element check condition #7060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

chirokas
Copy link
Contributor

Changed the logical operator from && to || because an element cannot be both document.documentElement and document.body at the same time.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@snowystinger
Copy link
Member

Was anything breaking with this? It'd be good to be able to verify the behavior update. This is a line from 4 years ago, so curious how you found it.

@snowystinger
Copy link
Member

No no, you misunderstand. I haven't seen it adversely affect anything. I'm curious how you noticed it.

@chirokas chirokas closed this Jan 1, 2025
@chirokas chirokas deleted the patch branch February 2, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants