Set default value for type parameter in SelectProps #7014

kp047i · 2024-09-09T10:40:35Z

✅ Pull Request Checklist:

Included link to corresponding React Spectrum GitHub Issue.
Added/updated unit tests and storybook for this change (for new code or code which already has tests).
Filled out test instructions.
Updated documentation (if it already exists for this component).
Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

* update illustrated message font size * remove v3 style props * remove unneccessary styling Co-authored-by: Yihui Liao <[email protected]>

* ActionMenu and positioning props for Menu

* Move Popover padding and add ref

* nextjs, macros, and components example app * package.json link path to rainbow was wrong * adding dropzone, taggroup, and illustratedmessage * using the npmjs version of unplogin-parcel-macros instead of linking * review feedback - config improvements Co-authored-by: Kyle Taborski <[email protected]>

* Avatar audit + fix to style macro to omit overriden default styles * removing avatars and isDisabled * audit button and buttongroup * more audit items * Adding component descriptions * Forgot to save * update with spectrum links and help text type update * properly only send DOM props to the Avatar * fix help text related types * update label type * whoops too much empty space * review comments

* I-P exports and descriptions

Menu has its own Divider so we can ensure style merge order (adobe#76)

* Use WF icons for InlineAlert * change prop name back * Get rid of cloneElement and use wrapper on context * swap to svgr and work on inline alert * fix sizing temporarily * Update all icon usages * inline styles, though i still think these are broken icons * review comments * update font colors of inline alert to match figma Co-authored-by: Daniel Lu <[email protected]>

* update type for Divider * update type for Dropzone * update type for Form * add JSDoc * update Divider JSDoc * Update Dropzone JSDoc * add more JSDocs * default Form size to M * formatting * add min height and width to divider based on orientation * switch defaults to medium values * update Divider large sizes * remove validationBehavior from Form * add PURE annotations Co-authored-by: Reid Barber <[email protected]> Co-authored-by: Rob Snow <[email protected]>

…ted, and other bug fixes (adobe#72) * adding ActionButton truncation and fixing Taggroup icon color when selected * fix icon only button sizing in ButtonGroup in safari not sure why the minWidth is being applied to non icon only buttons though... * Make help text not render anything if there isnt a error message to display when invalid * fix dropzone replace mesage banner positioning in Safari Co-authored-by: Rob Snow <[email protected]>

* update sizes to use auto instead of undefined * add none to theme * update to use none instead of auto * update style logic * Revert "add none to theme" This reverts commit 4f552e74de94475dd3809063b3a18ae548b3e740. * improve story * remove minWidth and minHeight Co-authored-by: Reid Barber <[email protected]>

* R-S audit * RadioGroup api audit and radio props from form context * renaming props and form props in radio * adding pure * updated comments and rest of files * fixing a variable usage Co-authored-by: Kyle Taborski <[email protected]>

Label breadcrumb collapse menu

* fix treeview stories controls * fix tree row padding if no checkbox and fix chromatic

snowystinger

Thanks for submitting!

I'm not sure the best way to mark this as deprecated now. Perhaps using overload syntax we could mark this particular signature as deprecated

* Fix icon builder dependencies

* replace Azure CLI with AzCopy * use wget * update command * remove azure-cli image * Revert "remove azure-cli image" This reverts commit 07b7ed0.

* fix path in verdaccio deploy * build on PR * revert * enable comments on PR * loop over verdaccio dir * add back branch filters

) * Allow layout delegate to override shift selection behavior * Fix virtualizer unmounting and remounting when changing layout options * Automatically reduce card size based on available space * Fix TS strict --------- Co-authored-by: Daniel Lu <[email protected]>

…rget (adobe#7026) Co-authored-by: Daniel Lu <[email protected]>

* initialize segemented file * add some styling * add track styling and hcm * fix hcm * remove unused imports * export properly, add font weight * default select first item, fix hcm * remove trackStyle prop * remove more trackStyle stuff, update css * update stories * fix types, add jsdoc comments * update story again oops * fix typo * fix types * remove space * add translation * update internal context prop name, add transition * remove transition, fix keyboard in rtl * update string formatter * initialize animations (it's very janky) * require aria label, remove translation * fix lint * fix ts * update props * fix spacing * add aria label to stories * update animation using flip, fix selectedValue when radio group is disabled * keep speed the same * fix lint and small other fixes * add icon only spacing * update segmented control item prop name * fix lint * small fixes * fix alignment with text and icons, fix wiggling for ltr * fix wiggling in rtl languages * update icon only buttons * revert useRadioGroupState change * revert changes to registration * fix lint --------- Co-authored-by: Robert Snow <[email protected]>

RAC and S2 Pending Button

Co-authored-by: Abel John <[email protected]> Co-authored-by: Robert Snow <[email protected]> Co-authored-by: Daniel Lu <[email protected]>

Co-authored-by: Daniel Lu <[email protected]>

Co-authored-by: Teemu Andersèn <[email protected]> Co-authored-by: Robert Snow <[email protected]> Co-authored-by: Reid Barber <[email protected]> Co-authored-by: Daniel Lu <[email protected]>

feat: forward styles to VirtualizerItem

@ts-ignore

* initialize accordion item * update yarn.lock * better hidden=until-found support * allow passing in panel ref * comments * use RAC in v3 Accordion * use disclosure hooks * initialize S2 Accordion * fix lint * add exports * lint * fix chevron color in dark mode * fix version of @react-stately/accordion * keep aria-controls even when closed * add isFocusVisibleWithin to AccordionPanel * fix panel height * fix versions * add to ts strict config * change open/close to expand/collapse * move to disclosure package * fix chevron shrinking on wrapping header text * support for disabled in S2 * clear ButtonContext in panel * update colors * lint * fix v3 chevron not rotating * don't open via onbeforematch if disabled * add disableTapHighlight * open disclosure onKeyDown * add getAllowedOverrides * remove outer header component * support level in S2 header * support level in v3 header * switch divider to use border * simplify focus ring and padding styles * update AccordionItem children types to enforce two React elements * remove Header from RAC example * scale font size * update yarn.lock * fix keydown interaction + types * support size, density, isQuiet, and isDisabled on individual items, but use group prop if available * enforce minWidth at item level * add isFocusVisibleWithin to item * fix chevron in RTL * revert changes to @react-aria/accordion * fix v3 chevron in RTL * fix packages/imports * use 'group' as default role * deprecate useAccordion and useAccordionItem * update prop JSDocs * update yarn.lock * fix v3 refs * add v3 tests back * update imports * remove @ts-ignore * Revert "remove @ts-ignore" This reverts commit 88c1604. * fix stories * fix context for individual accordion item * fix defaults for individual item * add story for individual item * make paddingTop and paddingBottom equal * fix story * change triggerProps to buttonProps * add optional ref to useDisclosure * add SSR check * use useEvent to add beforematch listener * rename AccordionGroup to Accordion * rename Disclosure to AccordionItem * rename AccordionPanel to DisclosurePanel * more renaming * rename RAC Accordion file to Disclosure * comment updates * package.json updates * yarn.lock * update render props * add DEFAULT_SLOT * use fontRelative for border radius * style macro updates * lint * update codemod * fix tests * use control for borderRadius * use ref instead of contentRef prop * use values on grid * lint * yarn.lock * fix refs * lint * revert renames in useAccordion * move Disclosure to its own file * reanme RAC Accordion stories to Disclosure * fix styles prop type * fix imports * update styles type on Disclosure * add dedicated story for S2 Disclosure * Slight fixes * Center baseline and simplify padding by changing the minHeight instead It uses more normal numbers * fix import * update lockfile --------- Co-authored-by: Devon Govett <[email protected]>

kp047i · 2024-09-21T05:25:15Z

@snowystinger
I tried using overload syntax to deprecate only the function signatures where a type parameter is provided, but I couldn’t get it to work. Here’s my attempt: TypeScript Playground.

Could you check if my approach is correct, and let me know if there’s a better way to achieve this?

Thanks!

Merge S1 and S2 chromatic storybooks

snowystinger

Hmmm, I am not good enough at Typescript to figure out how to do it. I had a good google around. Thanks for also checking that out and confirming it.

The merge-base changed after approval.

devongovett and others added 30 commits March 11, 2024 14:33

Theme audit (adobe#63)

9561f2f

Remove V3 StyleProps from IllustratedMessage (adobe#57)

f9276d2

* update illustrated message font size * remove v3 style props * remove unneccessary styling Co-authored-by: Yihui Liao <[email protected]>

ActionMenu and positioning props for Menu (adobe#61)

ebdf8f9

* ActionMenu and positioning props for Menu

Static backgrounds that don't interfere with state (adobe#56)

ba5341d

Move Popover padding and add ref (adobe#60)

5c3ec65

* Move Popover padding and add ref

setup chromatic (adobe#65)

1c63b44

Audit T components (adobe#68)

0c86c7e

fix outline button disabled and keyboard focus styles (adobe#69)

b4cc790

I-P Audit (adobe#70)

aaa295c

I-P exports and descriptions (adobe#74)

a2cedc3

* I-P exports and descriptions

Menu has its own Divider so we can ensure style merge order (adobe#76)

c480260

Menu has its own Divider so we can ensure style merge order (adobe#76)

Menu placement fixes (adobe#71)

c156532

Icon fixes from testing (adobe#79)

4eaf766

Icons move fallback color out of page (adobe#82)

2db28b9

R-S audit (adobe#75)

3fb81a6

* R-S audit * RadioGroup api audit and radio props from form context * renaming props and form props in radio * adding pure * updated comments and rest of files * fixing a variable usage Co-authored-by: Kyle Taborski <[email protected]>

Remove border radius for fullscreen takeover dialogs (adobe#78)

1e65bb9

Audit Menu/Dialog/StatusLight Components (adobe#80)

93c00c5

Dialog: Fixing header and close button position (adobe#81)

939f8fd

Setup build to publish package (adobe#73)

a4f7b8c

Build icons with parcel (adobe#85)

ccd8619

Fix popover tip separation (adobe#86)

466083f

Minor menu fixes (adobe#89)

6c21561

Publish fixes (adobe#90)

6ebe56d

swap vertical and horizontal (adobe#91)

a4c4460

snowystinger and others added 4 commits September 6, 2024 10:03

Label breadcrumb collapse menu (adobe#6979)

17ad099

Label breadcrumb collapse menu

Fix useId updater overwrite (adobe#6788)

4980928

Fix Tree row padding when chevron isn't present (adobe#6545)

db51509

* fix treeview stories controls * fix tree row padding if no checkbox and fix chromatic

Set default value for type parameter in SelectProps

bf5a11c

snowystinger reviewed Sep 9, 2024

View reviewed changes

snowystinger and others added 17 commits September 11, 2024 07:49

Fix icon builder dependencies (adobe#7018)

086ad31

* Fix icon builder dependencies

S2 CardView and ghost loading (adobe#6978)

8ab4f20

Use content hashes in CSS modules (adobe#7029)

437b381

CI: Improve build times with azcopy (adobe#7031)

7341499

* replace Azure CLI with AzCopy * use wget * update command * remove azure-cli image * Revert "remove azure-cli image" This reverts commit 07b7ed0.

CI: fix verdaccio deploy step (adobe#7035)

9da4651

* fix path in verdaccio deploy * build on PR * revert * enable comments on PR * loop over verdaccio dir * add back branch filters

Workaround Android issue where click events are fired on the wrong ta…

c904e06

…rget (adobe#7026) Co-authored-by: Daniel Lu <[email protected]>

Implement S2 ProgressCircle with SVG (adobe#7036)

2ca5989

Fix CardView quiet heights in Safari (adobe#7046)

9e79420

S2 Card updates (adobe#7053)

2bd6e20

RAC and S2 Pending Button (adobe#7002)

988b4d4

RAC and S2 Pending Button

fix conditional useHref call (adobe#7032)

097c8fc

Co-authored-by: Abel John <[email protected]> Co-authored-by: Robert Snow <[email protected]> Co-authored-by: Daniel Lu <[email protected]>

fix(internationalized/date): missing endOfWeek overload (adobe#6749)

b2e8ee6

Co-authored-by: Daniel Lu <[email protected]>

Fix useDateSegment null ref error adobe#6988 (adobe#6989)

53413af

Co-authored-by: Teemu Andersèn <[email protected]> Co-authored-by: Robert Snow <[email protected]> Co-authored-by: Reid Barber <[email protected]> Co-authored-by: Daniel Lu <[email protected]>

feat: forward styles VirtualizerItem (adobe#6998)

6193c40

feat: forward styles to VirtualizerItem

devongovett and others added 2 commits September 23, 2024 11:34

Add DisclosureGroup component to RAC (adobe#7063)

e87ee28

Merge S1 and S2 chromatic storybooks (adobe#6965)

5a0b4fa

Merge S1 and S2 chromatic storybooks

snowystinger previously approved these changes Sep 24, 2024

View reviewed changes

Merge branch 'main' into set-default-type-select

cfa635a

devongovett force-pushed the main branch from fc5c8bd to e60fb42 Compare September 28, 2024 00:55

devongovett force-pushed the main branch from a79adcf to 3013156 Compare September 30, 2024 21:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set default value for type parameter in SelectProps #7014

Set default value for type parameter in SelectProps #7014

kp047i commented Sep 9, 2024

snowystinger left a comment

kp047i commented Sep 21, 2024

snowystinger left a comment

Set default value for type parameter in SelectProps #7014

Are you sure you want to change the base?

Set default value for type parameter in SelectProps #7014

Conversation

kp047i commented Sep 9, 2024

✅ Pull Request Checklist:

📝 Test Instructions:

🧢 Your Project:

snowystinger left a comment

Choose a reason for hiding this comment

kp047i commented Sep 21, 2024

snowystinger left a comment

Choose a reason for hiding this comment