Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog pinch zoom #7012

Open
wants to merge 300 commits into
base: main
Choose a base branch
from
Open

Dialog pinch zoom #7012

wants to merge 300 commits into from

Conversation

tomdohnal
Copy link

Closes #1898

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

snowystinger and others added 30 commits February 15, 2024 11:20
@snowystinger
Update RAC (adobe#30)
5cc9494
@snowystinger
Buttongroup (adobe#29)
f3917a9 
* ButtonGroup
@devongovett
Setup npm build and codemods (adobe#22)
838cbbb
@LFDanLu
Fix lint and ts (adobe#35)
96f029f 
* fix lint

* fix typescript
@LFDanLu
Adding tsc to yarn lint (adobe#37)
e11353d
@devongovett
use light-dark() and color-scheme to implement dark mode (adobe#36)
420af50
@reidbarber
ProgressBar (adobe#26)
b97651b 
* initial add progress bar

* add animationIterationCount to theme

* add story decorators for static color backgrounds

* more style fixes

* more value fixes

* support classnames in field label

* cleanup

* cleanup

* address review comments

* add autodocs

* update size jsdoc

* fix label position and row gap

* use self(height) instead of new variable

* improve styles

* remove width prop

* move text static colors to FieldLabel

* use full border radius

* various color improvements

Co-authored-by: Reid Barber <[email protected]>
@devongovett
Setup i18n fonts (adobe#34)
e445bdc
@devongovett
Link (adobe#40)
6cabecb
@devongovett
Remove some events from storybook actions
3ae9002
@snowystinger
Precommit hook (adobe#39)
6c5dffd 
* Add pre commit hook for lint
@snowystinger
Fix lint and ts (adobe#43)
488fa8a
@reidbarber
remove focus behavior from Avatar (adobe#42)
8ac8f0f 
Co-authored-by: Reid Barber <[email protected]>
@reidbarber
TagGroup fixes from testing (adobe#41)
ce37bad 
* add new story with Tag links

* style cursor as pointer for links

* add Link to empty tag example

* remove errorMessage prop

* fix isEmphasized text color

* remove isRequired prop

* update field gap to match other fields

* make renderEmptyState font family sans

* remove dup key in theme

* fix WebkitTapHighlightColor for disabled tag

* remove WebkitTapHighlightColor handling

* cleanup stories

Co-authored-by: Reid Barber <[email protected]>
@ktabors
Picker input field styling (adobe#32)
d58af25 
* renaming to picker and adding initial style macro changes

* field and input styles added

* two quick style fixes from feedback

* removing staticColor, fixing isDisabled, and improving some prop handling

* lint spacing fixes

* fixing the focusRing after menu close

* quiet style as element with rounded ends

* undid testing mode

* implementing the isQuiet focus ring more closely, but looks less correct

* chevron icon cleanup

* refining styles based on feedback

Co-authored-by: Kyle Taborski <[email protected]>
@ktabors
Fixing look of touch events on iOS (adobe#44)
e5857d0 
Co-authored-by: Kyle Taborski <[email protected]>
@yihuiliao
Update IllustratedMessage to use ButtonGroup (adobe#46)
cdca4df 
Co-authored-by: Yihui Liao <[email protected]>
@yihuiliao
initial ref support (adobe#33)
541f5ce 
* initialize ref support

* add more ref support to components

* clean up

* more cleanup

* update refs

* remove dialog inner export, make helptext ref optional, fix ts

* more ts fixes

Co-authored-by: Yihui Liao <[email protected]>
@LFDanLu
Fix disabled, emphasized, selected ToggleButton style (adobe#47)
a372d92 
* Fix disabled, emphasized, selected ToggleButton style

* Make it so selected quiet disabled toggle buttons are consistent with the non quiet variant

at the moment the designs show that disabled toggle buttons shouldnt have any style differences whether they are selected or not

* make forced colors match when selected/not selected and disabled
@yihuiliao
Remove V3 styleProps in InlineAlert (adobe#45)
e9d00dd 
* Remove styleProps in InlineAlert

* create new styleProps with UNSAFE

* new file for styleProps

Co-authored-by: Yihui Liao <[email protected]>
@snowystinger
Wf icons (adobe#48)
e020394 
Workflow icons
@yihuiliao
add disabled to button group (adobe#49)
38ea317 
Co-authored-by: Yihui Liao <[email protected]>
@yihuiliao
fix link in taggroup empty state (adobe#54)
dc72275 
Co-authored-by: Yihui Liao <[email protected]>
@snowystinger
Popover and Menu (adobe#31)
d1516ab 
* Popover and Menu
@devongovett
Add StatusLight and bump spectrum tokens (adobe#51)
13d1ceb
@yihuiliao
Add isEmphasized to CheckboxGroup (adobe#50)
05b252a 
* add isEmphasized to CheckboxGroup

* omits isDisabled from DropZone

* prioritize checkbox group isEmphasized

Co-authored-by: Yihui Liao <[email protected]>
@devongovett
Add css prop and unsafe style support (adobe#52)
e754213
@LFDanLu
Use default cursor for help text on disabled elements (adobe#55)
5678af7
@devongovett
Add LinkButton component (adobe#58)
bd89829
Fix missing type in module (adobe#59)
b5fcffa
yihuiliao and others added 28 commits August 20, 2024 18:23
@yihuiliao
fix: truncate text in S2 ActionButton (adobe#6919)
5cd9581
@devongovett
Publish
87fc14a
@devongovett
update yarn.lock
69cc445
@snowystinger
TS Strict Stately List (adobe#6567)
8f3c0ea 
* TS Strict Stately List
@reidbarber
fix v3 storybook logo (adobe#6914)
a4d8b94
@reidbarber
fix(docs): cleanup warnings in docs (adobe#6857)
7336849 
* fix various docs warnings

* typo
@omarnyte @snowystinger @reidbarber
feat(RAC): Allow passing data attributes to FieldError (adobe#6895)
3aa13af 
* Allow passing data attributes to FieldError

* Update FieldError.tsx

just fixing some lint, not sure how it passed

---------

Co-authored-by: Robert Snow <[email protected]>
Co-authored-by: Reid Barber <[email protected]>
@reidbarber @snowystinger
docs(RSP): add TreeView docs (adobe#6744)
6b8cb7a 
* add RSP TreeView docs

* fix types

* address review comments

* fix typo

* add ActionGroup and ActionMenu examples

* address review comments

* remove comment

* Update packages/@react-spectrum/tree/docs/TreeView.mdx

---------

Co-authored-by: Robert Snow <[email protected]>
@reidbarber @snowystinger
@solimant @ktabors @mdhmaiti @Andarist
Revert reverts from before latest release (adobe#6926)
859615a 
* Update Picker placeholder to be shorter (adobe#6796)

* feat: Support fragments in collections (adobe#6430)

Co-authored-by: Reid Barber <[email protected]>
Co-authored-by: Robert Snow <[email protected]>

* Exposing prop disabledBehavior to TableView (adobe#6832)

* fix/bug useTablist adobe#5996 (adobe#6023)

* fix/bug useTabist adobe#5996 and added tests

* Extract `ToggleStateProps` type to use only what is needed in `useToggleState` (adobe#3836)

* Extract `ToggleStateProps` type to use only what is needed in `useToggleState`

---------

Co-authored-by: Robert Snow <[email protected]>
Co-authored-by: solimant <[email protected]>
Co-authored-by: Kyle Taborski <[email protected]>
Co-authored-by: Medhashis Maiti <[email protected]>
Co-authored-by: Mateusz Burzyński <[email protected]>
@reidbarber
feat: Codemod: handle legacy Link API (adobe#6907)
2e689d9 
* handle legacy Link API by removing a element

* handle custom link components
@LFDanLu
Maintain Table row interactive states if interactive and prevent visu…
22e803a 
…ally disabled state if non-interactive and disabled (adobe#6863)

* Maintain row active/hover styles if it is interactive and do not apply disabled styles if non-interactive and disabled
@snowystinger
Support and document preventFocusOnPress (adobe#6854)
b4093df 
Support and document preventFocusOnPress (adobe#6854)
@yihuiliao
feat: add rounded edges and side label to S2 progress bar (adobe#6918)
72ec2f5 
* feat: add rounded edges and side label to progress bar

* only add margin if label exists
@yihuiliao
feat: add subtle and outline fill to s2 badge (adobe#6898)
33e8655 
* feat: add subtle and outline fill to s2 badge

* update comment

* add transparent border, fix neutral outline color

* fix layout

* make props optional
@snowystinger
Fix lint job on CI (adobe#6921)
25a2a30 
* Fix lint job on CI
@davidcoleman007 @LFDanLu
working branch for supporting windows contributors (adobe#6313)
acddd45 
* remove --extensions as they are unnecessary

add is-mingw
use isMinGW to use proper slashes on windows git bash

* remove logs from preview builder

* is-mingw is a dev dep

* patching storybook-builder-parcel to solve windows forward slash issues

---------

Co-authored-by: David Coleman <[email protected]>
Co-authored-by: Daniel Lu <[email protected]>
@snowystinger
Fix Safari docs crash (adobe#6930)
c8e5ed4 
* Fix Safari docs crash
@reidbarber
Codemod: remove Section and Items imports if not used elsewhere in fi…
dcf312b 
…le (adobe#6908)
@LFDanLu
Fix TreeView so that the row height always matches the chevron height (…
95c8344 
…adobe#6950)
@reidbarber
feat: codemods for Badge and Well (adobe#6941)
32574f8 
* add Well codemod

* add migration docs for well

* add codemod for badge

* update well font

* add story for testing style macro

* add to migration docs
@unional
fix(RAC): Select when label is numeric 0 (adobe#6968)
a5679cd 
fixes adobe#6961

Co-authored-by: Homa Wong <[email protected]>
@reidbarber
docs(RSP): clean up TreeView docs (adobe#6959)
bb05fdc 
* add maxWidth to examples

* dedupe items
@reidbarber
fix: S2 upgrade assistant links and install step (adobe#6972)
82e10d3
@reidbarber
feat: add icon codemods (adobe#6958)
32f8b8d
@yihuiliao
bump: update s2 tokens to v46 (adobe#6948)
591e672 
* update tokens

* fix dragged theme

* remove deprecated token

* remove comment
@LFDanLu
Fixing Tags so they properly truncate if wider than the container (ad…
f365691 
…obe#6966)

* Fixing Tags so they properly truncate if wider than the container

* revert story change
@reidbarber
Merge branch 'main' into dialog-pinch-zoom
cb6ce15
@snowystinger
fix lint
65f219e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useDialog: Pinch-to-zoom on iOS