Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Deprecate old prop isTextInput on useFocusVisible #6954

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

snowystinger
Copy link
Member

Closes #5658

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Aug 27, 2024

@devongovett
Copy link
Member

Doesn't this change the behavior though? Why are we deprecating it?

@snowystinger
Copy link
Member Author

@devongovett i don't think so, at least, i didn't notice any changes in testing.
Idea came from @LFDanLu 's comment #5658 (comment)

@snowystinger snowystinger changed the title Deprecate old prop isTextInput on useFocusVisible chore: Deprecate old prop isTextInput on useFocusVisible Oct 16, 2024
@rspbot
Copy link

rspbot commented Oct 16, 2024

@rspbot
Copy link

rspbot commented Oct 16, 2024

## API Changes

@react-aria/focus

/@react-aria/focus:FocusRing

 FocusRing {
   autoFocus?: boolean
   children: ReactElement
   focusClass?: string
   focusRingClass?: string
-  isTextInput?: boolean
   within?: boolean = false
 }

/@react-aria/focus:FocusRingProps

 FocusRingProps {
   autoFocus?: boolean
   children: ReactElement
   focusClass?: string
   focusRingClass?: string
-  isTextInput?: boolean
   within?: boolean = false
 }

/@react-aria/focus:AriaFocusRingProps

 AriaFocusRingProps {
   autoFocus?: boolean
-  isTextInput?: boolean
   within?: boolean = 'false'
 }

@react-aria/interactions

/@react-aria/interactions:FocusVisibleProps

 FocusVisibleProps {
   autoFocus?: boolean
-  isTextInput?: boolean
 }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useFocusRing: isTextInput no longer toggling focus ring
4 participants