Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add contributing Q & A section #6951

Merged
merged 12 commits into from
Oct 15, 2024
Merged

docs: add contributing Q & A section #6951

merged 12 commits into from
Oct 15, 2024

Conversation

unional
Copy link
Contributor

@unional unional commented Aug 27, 2024

Closes #6937

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

doc only change.

@unional
Copy link
Contributor Author

unional commented Aug 27, 2024

Also I notice that after running yarn build, loading the project again in vscode will trigger the "Configure Exclude" popup.

Maybe we can exclude the build artifacts in .vscode/settings.json

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
@yihuiliao yihuiliao added this pull request to the merge queue Oct 15, 2024
Merged via the queue into adobe:main with commit 06cdad7 Oct 15, 2024
30 checks passed
@unional unional deleted the qa branch October 16, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@parcel/core: packages/@react-aria/virtualizer/src/index.ts does not export 'useVirtualizer'
4 participants