-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix initial isFocused
in useFocusRing
when autoFocus = true
#6824
Open
pvorona
wants to merge
229
commits into
adobe:main
Choose a base branch
from
pvorona:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+80,545
−25,819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update dependencies
Remove Tailwind
* initialize alert dialog * add alert dialog * update story, fix closing * remove comments * remove props.styles * update types * remove orientation prop * add aria-label to icons * fix lint --------- Co-authored-by: Yihui Liao <[email protected]>
* fix rendering TagGroup inside GridList * clear in GridListItem instead
* Keep focus inside of ComboboxInput
support hover events for Tab
* add script to test docs for warnings/errors * get links before testing * update yarn.lock * update script to get latest browser binaries first * support running with webkit and firefox * exit process at the end --------- Co-authored-by: Robert Snow <[email protected]>
reidbarber
requested changes
Aug 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Mind adding a test for this behavior?
Also, you'll need to sign the CLA, then close and re-open this PR for the build to pass.
devongovett
force-pushed
the
main
branch
2 times, most recently
from
September 30, 2024 21:00
a79adcf
to
3013156
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue when
useFocusRing
returnsisFocused = false
on the first render even whenautoFocus = true
is passed.✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: