fix: Move to yarn patches #6772
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6d9aadc.
snowystinger
force-pushed
the
move-to-yarn-patches
branch
from
8552c3f
to
03beadd
Compare
# Conflicts: # .yarn/patches/recast+0.23.6.patch # .yarn/patches/storybook-builder-parcel-https-7ea26540e8.patch # package.json # yarn.lock
devongovett
force-pushed
the
main
branch
2 times, most recently
from
a79adcf
to
3013156
Compare
snowystinger
force-pushed
the
move-to-yarn-patches
branch
from
a09c3cc
to
3678490
Compare
# Conflicts: # .yarn/patches/eslint-plugin-monorepo-npm-0.3.2-0a46659919.patch # .yarn/patches/recast-npm-0.23.6-518fb470cb.patch # .yarn/patches/storybook-builder-parcel-https-7ea26540e8.patch # package.json # packages/dev/parcel-transformer-mdx-docs/package.json # scripts/verdaccio.sh # yarn.lock
devongovett
force-pushed
the
move-to-yarn-patches
branch
from
a806344
to
fa79dc5
Compare
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
ALERT: This PR is incompatible with Lerna, we'll need to move manual releases over to yarn instead. @devongovettThis is no longer an issue, we do not depend on Lerna
Move us off of patch-package and use yarn's native support for patching https://yarnpkg.com/cli/patch
Of note, yarn patching syntax is incompatible with lerna, at least at the version we have. So I've taken the liberty of moving the CI stuff using lerna over to the yarn versioning.This will still be an issue for a real manual release until we can move to yarn for that as well.Need to consult with @LFDanLu why verdaccio isn't running locally for me anymore. Haven't been able to decipher it yet.
UPDATE: Verdaccio issue seems to be some sort of a cache issue, as long as there is only one verdaccio server possible, everyone should be fine. Hopefully this is an issue with Yarn and will be updated in the future
Will need something like yarnpkg/berry#6420 to debug further. Again, everyone should be fine as verdaccio is seldom needed locally and we only use verdaccio.sh. I've removed the competing one, test-prod.sh, which had a different port.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: