Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter while typing and reduce number #659

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

kptdobe
Copy link
Contributor

@kptdobe kptdobe commented Sep 25, 2024

Make the list smaller and filter while typing with a startsWith

https://domains-tweaks--helix-website--adobe.aem.live/tools/rum/explorer.html?domain=

Copy link

aem-code-sync bot commented Sep 25, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Sep 25, 2024

Page Scores Audits Google
📱 /tools/rum/explorer.html?domain= PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /tools/rum/explorer.html?domain= PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Member

@maxakuru maxakuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the datalist should filter on input by default.. I'm guessing this is because 100 is an overwhelming amount? that's fair

@kptdobe
Copy link
Contributor Author

kptdobe commented Sep 26, 2024

the datalist should filter on input by default

It does but not like a autocomplete, it searches in the whole strings.
100 is not an issue for the autocomplete but for the UX: it's just too big.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants