Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set correct svg namespace for title element #431

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

fkakatie
Copy link
Member

@fkakatie fkakatie commented Dec 6, 2023

Description

Explicitly create the title element with the SVG namespace using document.createElementNS to prevent the addition of an unwanted xmlns attribute during serialization.

Related Issue

Resolves an issue where the title element was being treated as an XHTML element.

How Has This Been Tested?

https://svg-doctor--helix-website--adobe.hlx.live/tools/svg-doctor/

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

aem-code-sync bot commented Dec 6, 2023

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Dec 6, 2023

Page Scores Audits Google
/tools/svg-doctor/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

aem-code-sync bot commented Jan 9, 2024

Page Scores Audits Google
/tools/svg-doctor/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant