Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Including html forms in markdown #380

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Including html forms in markdown #380

wants to merge 2 commits into from

Conversation

jalagari
Copy link

Please ensure your pull request adheres to the following guidelines:

  • make sure to link the related issues in this description
  • when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues #379

Thanks for contributing!

@jalagari jalagari marked this pull request as draft January 19, 2024 18:10
tripodsan
tripodsan requested changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@tripodsan tripodsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, but this is cannot be supported as it doesn't conform the markup semantics of the helix pipeline.

@jalagari
Copy link
Author

Discussion at https://cq-dev.slack.com/archives/C05QU7MMRNF/p1705690163398589

trieloff
trieloff requested changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@trieloff trieloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's find a way that is architecturally consistent with the overall Helix ecosystem.

src/process-forms.js
children: [{
type: 'text',
tagName: 'code',
value: JSON.stringify(formDef),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not dump raw JSON into the content bus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tripodsan tripodsan tripodsan requested changes

@trieloff trieloff trieloff requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jalagari @trieloff @tripodsan