fix(breaking-change): update for nodes 18 and 20 (#53)

adobe · Nov 23, 2023 · 0fd86c3 · 0fd86c3
1 parent a23494e
commit 0fd86c3
Show file tree

Hide file tree

Showing 8 changed files with 12 additions and 12 deletions.
diff --git a/.github/workflows/daily.yml b/.github/workflows/daily.yml
@@ -11,7 +11,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        node-version: [14]
+        node-version: [18]
         os: [ubuntu-latest]
 
     steps:
@@ -30,5 +30,5 @@ jobs:
         env:
           SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
           SLACK_TITLE: 'Node version'
-          SLACK_MESSAGE: ${{ matrix.node }}
+          SLACK_MESSAGE: ${{ matrix.node-version }}
           SLACK_COLOR: ${{ job.status == 'success' && 'good' || job.status == 'cancelled' && '#808080' || 'danger' }}
diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml
@@ -14,7 +14,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        node-version: [14.x, 16.x]
+        node-version: [18.x, 20.x]
         os: [ubuntu-latest, windows-latest]
 
     steps:

diff --git a/.github/workflows/on-push-publish-to-npm.yml b/.github/workflows/on-push-publish-to-npm.yml
@@ -13,7 +13,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v1
         with:
-          node-version: 14
+          node-version: 18
       - run: npm install
       - run: npm test
       - uses: JS-DevTools/npm-publish@v1

diff --git a/.github/workflows/prerelease.yml b/.github/workflows/prerelease.yml
@@ -22,7 +22,7 @@ jobs:
           git config user.email [email protected]
       - uses: actions/setup-node@v1
         with:
-          node-version: 16
+          node-version: 18
       - run: |
           npm install
           npm test

diff --git a/.github/workflows/version-bump-publish.yml b/.github/workflows/version-bump-publish.yml
@@ -21,7 +21,7 @@ jobs:
           git config user.email [email protected]
       - uses: actions/setup-node@v1
         with:
-          node-version: 14
+          node-version: 18
       - run: |
           npm install
           npm test

diff --git a/lib/constants.js b/lib/constants.js
@@ -28,6 +28,6 @@ module.exports = {
   },
   appConfigFile: 'app.config.yaml',
   runtimeManifestKey: 'runtimeManifest',
-  nodeEngines: '^14.18 || ^16.13 || >=18',
-  defaultRuntimeKind: 'nodejs:16'
+  nodeEngines: '>=18',
+  defaultRuntimeKind: 'nodejs:18'
 }
diff --git a/package.json b/package.json
@@ -15,7 +15,7 @@
     "url": "https://github.com/adobe/generator-app-common-lib.git"
   },
   "engines": {
-    "node": "^14.18 || ^16.13 || >=18"
+    "node": ">=18"
   },
   "devDependencies": {
     "@types/jest": "^29.5.0",

diff --git a/test/lib/EventGenerator.test.js b/test/lib/EventGenerator.test.js
@@ -230,7 +230,7 @@ describe('implementation', () => {
                 'test-action-name-existing': {
                   function: 'actions/generic/index.js',
                   web: 'yes',
-                  runtime: 'nodejs:16',
+                  runtime: 'nodejs:18',
                   inputs: {
                     LOG_LEVEL: 'debug'
                   },
@@ -290,7 +290,7 @@ describe('implementation', () => {
                 'test-action-name-prev': {
                   function: 'actions/generic/index.js',
                   web: 'yes',
-                  runtime: 'nodejs:16',
+                  runtime: 'nodejs:18',
                   inputs: {
                     LOG_LEVEL: 'debug'
                   },
@@ -348,7 +348,7 @@ describe('implementation', () => {
                 'test-action-name-existing': {
                   function: 'actions/generic/index.js',
                   web: 'yes',
-                  runtime: 'nodejs:16',
+                  runtime: 'nodejs:18',
                   inputs: {
                     LOG_LEVEL: 'debug'
                   },