fix: update launch.json to skip internal/node_modules (#262)

adobe · Aug 15, 2024 · 228694c · 228694c
1 parent 34ed1e9
commit 228694c
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 8 deletions.
diff --git a/generators/add-vscode-config/index.js b/generators/add-vscode-config/index.js
@@ -44,15 +44,20 @@ class AddVsCodeConfig extends Generator {
 
   initializing () {
     this.vsCodeConfig = {
-      version: '0.2.0',
+      version: '0.3.0',
       configurations: []
     }
 
     this.vsCodeConfig.configurations.push({
       name: 'App Builder: debug actions',
       type: 'node-terminal',
       request: 'launch',
-      command: 'aio app dev'
+      command: 'aio app dev',
+      skipFiles: [
+        '<node_internals>/**/*.js',
+        // eslint-disable-next-line no-template-curly-in-string
+        '${workspaceFolder}/node_modules/**/*.js'
+      ]
     })
 
     this.vsCodeConfig.configurations.push({
@@ -61,13 +66,20 @@ class AddVsCodeConfig extends Generator {
       request: 'launch',
       command: 'aio app dev',
       sourceMapPathOverrides: {
-        '/__parcel_source_root/*': '${webRoot}/*' // eslint-disable-line no-template-curly-in-string
+        // eslint-disable-next-line no-template-curly-in-string
+        '/__parcel_source_root/*': '${webRoot}/*'
       },
+      skipFiles: [
+        '<node_internals>/**/*.js',
+        // eslint-disable-next-line no-template-curly-in-string
+        '${workspaceFolder}/node_modules/**/*.js'
+      ],
       serverReadyAction: {
         pattern: 'server running on port : ([0-9]+)',
         uriFormat: 'https://localhost:%s',
         action: 'debugWithChrome',
-        webRoot: '${workspaceFolder}' // eslint-disable-line no-template-curly-in-string
+        // eslint-disable-next-line no-template-curly-in-string
+        webRoot: '${workspaceFolder}'
       }
     })
   }

diff --git a/test/__fixtures__/add-vscode-config/launch.json b/test/__fixtures__/add-vscode-config/launch.json
@@ -1,20 +1,27 @@
 {
-  "version": "0.2.0",
+  "version": "0.3.0",
   "configurations": [
     {
       "name": "App Builder: debug actions",
       "type": "node-terminal",
       "request": "launch",
-      "command": "aio app dev"
-    },
-    {
+      "command": "aio app dev",
+      "skipFiles": [
+        "<node_internals>/**/*.js",
+        "${workspaceFolder}/node_modules/**/*.js"
+    ]
+    }, {
       "name": "App Builder: debug full stack",
       "type": "node-terminal",
       "request": "launch",
       "command": "aio app dev",
       "sourceMapPathOverrides": {
         "/__parcel_source_root/*": "${webRoot}/*"
       },
+      "skipFiles": [
+        "<node_internals>/**/*.js",
+        "${workspaceFolder}/node_modules/**/*.js"
+     ],
       "serverReadyAction": {
         "pattern": "server running on port : ([0-9]+)",
         "uriFormat": "https://localhost:%s",