Added fix for istio gateway and vs heterogenous deployment (#6)

adobe · Jan 30, 2024 · 90a359f · 90a359f
1 parent eee36ee
commit 90a359f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/charts/external-dns/templates/deployment.yaml b/charts/external-dns/templates/deployment.yaml
@@ -84,6 +84,9 @@ spec:
             {{- if .Values.triggerLoopOnEvent }}
             - --events
             {{- end }}
+            {{- if .Values.awsPreferCname }}
+            - --aws-prefer-cname
+            {{- end }}
             {{- if .Values.watchNamespaces }}
             - --namespace={{ .Values.watchNamespaces | join "," }}
             {{- end }}

diff --git a/source/istio_virtualservice.go b/source/istio_virtualservice.go
@@ -459,13 +459,14 @@ func (sc *virtualServiceSource) targetsFromGateway(ctx context.Context, gateway
 		return
 	}
 
-	services, err := sc.serviceInformer.Lister().Services(sc.namespace).List(labels.Everything())
+	// Use kubeclient instead of informers to fetch services from gateway namespace
+	services, err := sc.kubeClient.CoreV1().Services(gateway.Namespace).List(ctx, metav1.ListOptions{})
 	if err != nil {
 		log.Error(err)
 		return
 	}
 
-	for _, service := range services {
+	for _, service := range services.Items {
 		if !gatewaySelectorMatchesServiceSelector(gateway.Spec.Selector, service.Spec.Selector) {
 			continue
 		}