13. Pricing Page Alignment from sheet

.eslintrc.js

@@ -15,6 +15,7 @@ module.exports = {
   extends: '@adobe/helix',
   env: {
     browser: true,
+    mocha: true,
   },
   rules: {
     // allow reassigning param
@@ -23,6 +24,14 @@ module.exports = {
     'import/extensions': ['error', {
       js: 'always',
     }],
+    'no-unused-expressions': 0,
+  },
+  settings: {
+    'import/resolver': {
+      node: {
+        extensions: ['.js', '.jsx', '.ts', '.tsx'],
+      },
+    },
   },
   parser: '@babel/eslint-parser',
   parserOptions: {

.github/codeql/codeql-config.yml

@@ -0,0 +1,4 @@
+name: "Express CodeQL Config"
+
+paths-ignore:
+  - node_modules

.github/pull_request_template.md

@@ -1,7 +1,7 @@
-Please always provide the [JIRA issue(s)](https://jira.corp.adobe.com/secure/RapidBoard.jspa?rapidView=34618) your PR is for, as well as test URLs where your change can be observed (before and after):
+Describe your specific features or fixes
 
-Fix <jira-issue-id>
+Resolves: [MWPW-NUMBER](https://jira.corp.adobe.com/browse/MWPW-NUMBER)
 
 Test URLs:
-- Before: https://main--express-website--adobe.hlx.page/express/
-- After: https://<branch>--express-website--adobe.hlx.page/express/
+- Before: https://main--express--adobecom.hlx.page/express/
+- After: https://<branch>--express--adobecom.hlx.page/express/

.github/workflows/codeql.yml

@@ -0,0 +1,66 @@
+# For most projects, this workflow file will not need changing; you simply need
+# to commit it to your repository.
+#
+# You may wish to alter this file to override the set of languages analyzed,
+# or to provide custom queries or build logic.
+#
+# ******** NOTE ********
+# We have attempted to detect the languages in your repository. Please check
+# the `language` matrix defined below to confirm you have the correct set of
+# supported CodeQL languages.
+#
+name: "CodeQL"
+
+on:
+  push:
+    branches: [ "main", "stage" ]
+  pull_request:
+    # The branches below must be a subset of the branches above
+    branches: [ "main", "stage" ]
+  schedule:
+    - cron: '18 6 * * 5'
+
+jobs:
+  analyze:
+    name: Analyze
+    runs-on: ubuntu-latest
+    permissions:
+      actions: read
+      contents: read
+      security-events: write
+
+    strategy:
+      fail-fast: false
+      matrix:
+        language: [ 'javascript' ]
+
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v3
+
+      # Initializes the CodeQL tools for scanning.
+      - name: Initialize CodeQL
+        uses: github/codeql-action/init@v2
+        with:
+          languages: ${{ matrix.language }}
+          config-file: ./.github/codeql/codeql-config.yml
+
+      # Autobuild attempts to build any compiled languages  (C/C++, C#, or Java).
+      # If this step fails, then you should remove it and run the build manually (see below)
+      - name: Autobuild
+        uses: github/codeql-action/autobuild@v2
+
+      # ℹ️ Command-line programs to run using the OS shell.
+      # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
+
+      #   If the Autobuild fails above, remove it and uncomment the following three lines.
+      #   modify them (or add more) to build your code if your project, please refer to the EXAMPLE below for guidance.
+
+      # - run: |
+      #   echo "Run, Build Application using script"
+      #   ./location_of_script_within_repo/buildscript.sh
+
+      - name: Perform CodeQL Analysis
+        uses: github/codeql-action/analyze@v2
+        with:
+          category: "/language:${{matrix.language}}"

.github/workflows/run-tests.yaml

@@ -1,18 +1,40 @@
 name: Tests and Linting
-
-on: [pull_request]
-
+on:
+  push:
+    branches: [ "main", "stage" ]
+  pull_request:
+    types: [opened, synchronize, reopened, edited]
+    branches: [ "main", "stage" ]
 jobs:
   build:
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        node-version: [14.x]
     steps:
-    - uses: actions/checkout@v3
-    - name: Use Node.js
-      uses: actions/setup-node@v3
-      with:
-        node-version: '14'
-    - run: npm install
-    - run: npm run lint
-    - run: npm test
-      env:
-        CI: true
+      - name: Checkout repository
+        uses: actions/checkout@v3
+        with:
+          fetch-depth: 2
+
+      - name: Set up Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v3
+        with:
+          node-version: ${{ matrix.node-version }}
+
+      - name: Install XVFB
+        run: sudo apt-get install xvfb
+
+      - name: Install dependencies
+        run: npm ci
+
+      - name: Run linters
+        run: npm run lint
+
+      - name: Run the tests
+        run: xvfb-run -a npm test
+
+      - name: Upload coverage to Codecov
+        uses: codecov/codecov-action@v3
+        with:
+          files: coverage/lcov.info

express/blocks/app-banner/app-banner.js

@@ -202,5 +202,11 @@ export default async function decorate($block) {
         watchFloatingButtonState($block);
       }, 1000);
     }
+
+    const blockLinks = $block.querySelectorAll('a');
+    if (blockLinks && blockLinks.length > 0) {
+      const linksPopulated = new CustomEvent('linkspopulated', { detail: blockLinks });
+      document.dispatchEvent(linksPopulated);
+    }
   }
 }

express/blocks/app-store-blade/app-store-blade.js

@@ -12,7 +12,11 @@
 
 import {
   createOptimizedPicture,
-  createTag, fetchPlaceholders, getIcon, getIconElement, getMetadata,
+  createTag,
+  fetchPlaceholders,
+  getIcon,
+  getIconElement,
+  getMetadata,
 } from '../../scripts/scripts.js';
 
 /**
@@ -233,4 +237,9 @@ export default async function decorate($block) {
   $block.innerHTML = '';
 
   decorateBlade($block, payload);
+  const blockLinks = $block.querySelectorAll('a');
+  if (blockLinks && blockLinks.length > 0) {
+    const linksPopulated = new CustomEvent('linkspopulated', { detail: blockLinks });
+    document.dispatchEvent(linksPopulated);
+  }
 }

express/blocks/app-store-highlight/app-store-highlight.js

@@ -273,4 +273,10 @@ export default async function decorate($block) {
   decorateGallery($block, payload);
   decorateAppStoreIcon($block, payload);
   initScrollAnimation($block);
+
+  const blockLinks = $block.querySelectorAll('a');
+  if (blockLinks && blockLinks.length > 0) {
+    const linksPopulated = new CustomEvent('linkspopulated', { detail: blockLinks });
+    document.dispatchEvent(linksPopulated);
+  }
 }