This repository has been archived by the owner on Nov 13, 2023. It is now read-only.
[MWPW-133406] [HOTFIX]: Relevant Rows regression caused by template v2 release #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
|
JingleH
approved these changes
Jul 3, 2023
|
I am not seeing this as resolved on this branch, it looks like template-x.js is not imported on this version, which is causing that entire section to break as well.
|
|
Duplicate Stage -> Main version merged. Closing this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MWPW-133406
Description:
A regression caused by template v2 refactoring where the toolbar got rendered on relevant rows as well. This fix removes 'mini' version of the template-list from the toolbar rendering logic.
Test URLs: (mobile only)
Before: https://stage--express-website--adobe.hlx.page/express/create/agenda?lighthouse=on
After: https://mwpw-133406-hotfix--express-website--wbstry.hlx.page/express/create/agenda?lighthouse=on