Skip to content
This repository has been archived by the owner on Nov 13, 2023. It is now read-only.

fix(untranslated-ckg-pills): metadata key fix & CKG pill altText logic fix #939

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

qiyundai
Copy link
Collaborator

@qiyundai qiyundai commented Jun 29, 2023

Please always provide the JIRA issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix MWPW-133351

Dscription
A couple things were changed last minute during the release. Some of these changes caused a low-exposure regression on the CKG pill. There's the quick fix for it.

Fixes includes:

  • If existing SEO pages are found, they should be prepended (prioritized)
  • If no translated name found for non-EN search pages, hide the pill.

Test URLs:

@aem-code-sync
Copy link

aem-code-sync bot commented Jun 29, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Jun 29, 2023

Page Scores Audits Google
/jp/express/templates/flyer/donation?lighthouse=on Lighthouse returned error: NO_FCP. The page did not paint any content. Please ensure you keep the browser window in the foreground during the load and try again. (NO_FCP) PSI

@JingleH JingleH merged commit 599da56 into adobe:stage Jul 17, 2023
2 of 3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants