This repository has been archived by the owner on Nov 13, 2023. It is now read-only.
Release Template-v2 [Second Try] #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update fetch limit to point at different cache * adding missed default content replacement * fixing legacy logic --------- Co-authored-by: Qiyun Dai <[email protected]>
Co-authored-by: Qiyun Dai <[email protected]>
|
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
|
|
qiyundai
approved these changes
Jun 26, 2023
apganapa
approved these changes
Jun 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix https://jira.corp.adobe.com/browse/MWPW-133170
Release wiki: https://wiki.corp.adobe.com/display/adobedotcom/Templates+v2+Release
All code changes should be backward-compatible. Namely, after code merged, old content should still display fine
Samples of potentially impacted pages to be verified:
https://www.adobe.com/express/templates/
https://www.adobe.com/express/templates/flyer/christmas
https://www.adobe.com/express/templates/search?tasks=banner&phformat=2:3&topics=hello&q=hello
https://www.adobe.com/express/templates/create/flyer
https://www.adobe.com/fr/express/
https://www.adobe.com/express/learn/students
Test URLs:
Before: https://main--express-website--adobe.hlx.live/express/templates/flyer/christmas?lighthouse=on
After: https://stage--express-website--adobe.hlx.page/express/templates/flyer/christmas?lighthouse=on