Skip to content
This repository has been archived by the owner on Nov 13, 2023. It is now read-only.

Template v2 release fixes #926

Merged
merged 4 commits into from
Jun 26, 2023
Merged

Template v2 release fixes #926

merged 4 commits into from
Jun 26, 2023

Conversation

JingleH
Copy link
Collaborator

@JingleH JingleH commented Jun 26, 2023

Please always provide the JIRA issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix

Test URLs:

@aem-code-sync
Copy link

aem-code-sync bot commented Jun 26, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Jun 26, 2023

Page Scores Audits Google
/express/templates/search?tasks=flyer&phformat=2:3&topics=happy%20dog&q=happy%20dog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/express/templates/search Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 404) PSI

@JingleH JingleH merged commit 88da351 into stage Jun 26, 2023
2 of 3 checks passed
@JingleH JingleH deleted the template-v2-release-fixes branch June 26, 2023 17:35
JingleH added a commit that referenced this pull request Jun 26, 2023
* update fetch limit to point at different cache

* adding missed default content replacement

* fixing legacy logic

---------

Co-authored-by: Qiyun Dai <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants