This repository has been archived by the owner on Nov 13, 2023. It is now read-only.
Release Template-V2 #917
Merged
Release Template-V2 #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* searchmarquee+ckgpills+categorylist+performance * nonblocking block-loading * mwpw-131491 fallback error message * performance: dynamic limitCnt on screenSizes * fix(props-scope-limit): done (#850) * [MWPW-131914] Load Better Img in background (#851) * fix(load-better): done * fix(load-better): fixed loadMoreButton bug * fix(template-list): adding back lastRow remove to fix query url * [MWPW-131912] Lazy Load templates.js (#853) * small regression fix * templates.js revamp * LCP configuration * update LCP function (#854) * dynamic load search marquee autocomplete (#855) * dynamic load search marquee autocomplete * small css fix * [MWPW-131912-4]: attempt to fix CLS opportunities (#856) * attempt to fix CLS opportunities * remove hard coded width * Template list revamp perf (#859) * misc improvements * back to use dummy image --------- Co-authored-by: Jingle Huang <[email protected]> * fixmes for now having only one template-list block * [MWPW-131458] Page restructure related fixes (#865) * refactored fetchSheetData * [MWPW-132212] Template v2 Search Feature Update (#870) * search function done for EN * reinstate sheet powered page validation * findMatchExistingSEOPage col name update * redirectSearch col name update * renaming vars * breadcrumbs initial impl * breadcrumbs desktop only * [MWPW-132220] Template-v2: Investigate CKG Default Bottom of the Pages (#875) * only append SEO linklist if replaceable pill found * added min-height to prevent list clipping * add locale referencing in sheet fetch * load templates.js after all blocks loaded * hide search-marquee on non-desktop * move templates.js out of scripts.js * added template-list tasks fallback * await heading update * 1st fallback with only tasks * [MWPW-131458] Template List CSS Tweak (#881) * CSS tweaking for new template-list * Update template-list.css * [MWPW-131458-3] Template List v2 QA round 2 (#884) * [MWPW-131458-3] Template List QA round 2 * [MWPW-131458-3] fallback text fix * tweaking template-list padding * Update template-list.css * fix desktop and mobile category list structure conflict * fix(search-marquee): shouldn't always fire search with current tasks * accessibility breadcrumbs * hide breadcrumbs for templates * suppress gnav breadcrumbs for templates (#890) * no gnav breadcrumbs for templates * use null than undefined --------- Co-authored-by: Jingle Huang <[email protected]> * remove template-list FIXME * sanitize breadcrumbs * fix await * remove sticky searchbar unpredictable JS based hover effect * hide non-en template breadcrumbs * Template list backward compatible (#896) * attemp backward compatability * memoize to prevent double fetch * adjust breadcrumbs and searchbar on old content * added ckgid metadata --------- Co-authored-by: Jingle Huang <[email protected]> * fix(template-list-v2): ckg pill fetch fix * fix(content-replacement): scope expansion * better backward compatibility * fix(template-list) simplify fetchLegacyAllTemplatesMetadata * fix(template-list): metadata fetch fallback logic fix * import fix * test * adding TODO * oldSheet templateTasks * wip * localized breadcrumbs * [MWPW-129863] Template v2 QA round 4 (#898) backward compatibility with old/new sheet column mapping * sanitize shorttitle * fix * stop expecting ratios to always be specified (#901) * Fallback check for placeholder format (#902) * stop expecting ratios to always be specified * PH ratio fallback fix * defaulting placeholder format (#903) * use ratio from metadata as fallback * use ratio from metadata as fallback * rebase to revamp branch form upstream * use getMetadata in constructprops * Update all-templates-metadata.js (#904) * object adaptation correction (#905) * add missing await (#906) * object adaptation correction * add missing await * add missing await * task sanitization (#907) * categorylist straight redirect (#900) Co-authored-by: Jingle Huang <[email protected]> * add trailing slash to breadcrumbs (#899) Co-authored-by: Jingle Huang <[email protected]> * bring back categoryList cnt * sanitize task, topic and q (#908) * [MWPW-133057] Search Marquee Keyword Tracking (#909) * fix(search-bar-tracking): initial setup. might just work. * body json format fix * fix(search-tracking): send raw timestamp * showLinkLIst default true * added template-list error handling * fix decorateLinklist * [MWPW-133097] Long Text Block - 1st Iteration (#911) * setup long txt block * feat(long-text): basic feature / responsiveness done * fix(long-text): future-proof * feat(search-tracking): adding audience and mobile support (#913) * Reduce tbt (#910) * try to improve updatePage performance * code styles --------- Co-authored-by: Jingle Huang <[email protected]> * fix regex * copy over new repo browse-by-category block * fix for create pages * f * fix searchMarquee for templates root page * fix regex --------- Co-authored-by: Jingle Huang <[email protected]> Co-authored-by: Qiyun Dai <[email protected]>
* update templatelist-horizontal + browse-by-cat max-width * bro-by-cat css * searchMar show by default * breadcrumbs handle missing shortTitle --------- Co-authored-by: Jingle Huang <[email protected]>
|
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
|
vhargrave
suggested changes
Jun 26, 2023
|
Switching back and forth between the filter for oldest to newest and newest to oldest is showing some of the same results at the top. That seems completely wrong to me Screen.Recording.2023-06-26.at.10.04.09.mov |
|
On mobile there probably shouldn't be a large space between the search field and content below. |
This search suggestion list is likely not done being authored yet. And, If a templates/ link returns an empty page with no title like that, it's because the metadata sheet doesn't have a row for it. In prod environment, this type of pages will be properly handled and actually redirect to express/templates root page. |
ok, if you're sure then we're good 👍 |
|
qiyundai
approved these changes
Jun 26, 2023
apganapa
approved these changes
Jun 26, 2023
vhargrave
approved these changes
Jun 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix https://jira.corp.adobe.com/browse/MWPW-133170
Release wiki: https://wiki.corp.adobe.com/display/adobedotcom/Templates+v2+Release
All code changes should be backward-compatible. Namely, after code merged, old content should still display fine
Samples of potentially impacted pages to be verified:
Test URLs: