This repository has been archived by the owner on Nov 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
|
JingleH
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and I am approving, but I think we need to be very cautious before bringing this into scripts.js and potentially affecting our performance. We can talk about how to proceed later
qiyundai
reviewed
Jun 22, 2023
qiyundai
reviewed
Jun 22, 2023
qiyundai
reviewed
Jun 22, 2023
|
|
qiyundai
approved these changes
Jun 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
apganapa
added a commit
that referenced
this pull request
Jun 23, 2023
MWPW-130556 | Adding WebPage Schema (#912)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add webPage schema block to pages. Currently block created needs to be added on the document so that webPage gets added.
this is for testing IN locale with 5 pages.
Once SEO team confirms to go forward with all locales and all pages then the code will get moved to scripts.js
Fix MWPW-130556
Test URLs: