Skip to content
This repository has been archived by the owner on Nov 13, 2023. It is now read-only.

MWPW-130556 | Adding WebPage Schema #912

Merged
merged 5 commits into from
Jun 23, 2023
Merged

MWPW-130556 | Adding WebPage Schema #912

merged 5 commits into from
Jun 23, 2023

Conversation

apganapa
Copy link
Collaborator

@apganapa apganapa commented Jun 22, 2023

This will add webPage schema block to pages. Currently block created needs to be added on the document so that webPage gets added.
this is for testing IN locale with 5 pages.
Once SEO team confirms to go forward with all locales and all pages then the code will get moved to scripts.js

Fix MWPW-130556

Test URLs:

@aem-code-sync
Copy link

aem-code-sync bot commented Jun 22, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Jun 22, 2023

Page Scores Audits Google
/in/express/feature/image/test-schema-qr-code-generator PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Collaborator

@JingleH JingleH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and I am approving, but I think we need to be very cautious before bringing this into scripts.js and potentially affecting our performance. We can talk about how to proceed later

@aem-code-sync
Copy link

aem-code-sync bot commented Jun 22, 2023

Page Scores Audits Google
/in/express/feature/image/test-schema-qr-code-generator PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Jun 23, 2023

Page Scores Audits Google
/in/express/feature/image/test-schema-qr-code-generator PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Collaborator

@qiyundai qiyundai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@apganapa apganapa merged commit 50dba13 into stage Jun 23, 2023
@apganapa apganapa deleted the MWPW-130556 branch June 23, 2023 02:27
apganapa added a commit that referenced this pull request Jun 23, 2023
MWPW-130556 | Adding WebPage Schema (#912)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants